Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2469963003: arc: Add methods to IntentHelperInstance to read ARC contents (Closed)

Created:
4 years, 1 month ago by hashimoto
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Add methods to IntentHelperInstance to read ARC contents BUG=654684 Committed: https://crrev.com/6f10b685c5aa13623e76e101e5f22e6b164221d7 Cr-Commit-Position: refs/heads/master@{#430185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M components/arc/common/intent_helper.mojom View 4 chunks +9 lines, -2 lines 0 comments Download
M components/arc/test/fake_intent_helper_instance.h View 2 chunks +6 lines, -0 lines 0 comments Download
M components/arc/test/fake_intent_helper_instance.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
hashimoto
This is part of a series of CLs: 1. https://codereview.chromium.org/2469963003 Add methods to IntentHelperInstance to ...
4 years, 1 month ago (2016-11-02 08:43:54 UTC) #6
hashimoto
Correction: #2 (2467213002) is not meant to be submitted. The next CL is #3 (2464333003).
4 years, 1 month ago (2016-11-02 08:46:43 UTC) #7
rickyz (no longer on Chrome)
mojom lgtm (just to make sure, these are IPCs implemented on the Android side that ...
4 years, 1 month ago (2016-11-02 19:55:02 UTC) #8
hashimoto
On 2016/11/02 19:55:02, rickyz wrote: > mojom lgtm (just to make sure, these are IPCs ...
4 years, 1 month ago (2016-11-04 00:12:19 UTC) #9
hidehiko
lgtm
4 years, 1 month ago (2016-11-04 17:08:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469963003/1
4 years, 1 month ago (2016-11-06 04:26:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-06 04:57:44 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-06 04:59:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f10b685c5aa13623e76e101e5f22e6b164221d7
Cr-Commit-Position: refs/heads/master@{#430185}

Powered by Google App Engine
This is Rietveld 408576698