Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2464333003: arc: Add utility functions to implement ARC content file system (Closed)

Created:
4 years, 1 month ago by hashimoto
Modified:
4 years, 1 month ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Add utility functions to implement ARC content file system Add intent_helper_util to use IntentHelperInstance from IO thread. Add FileSystemUrlToArcUrl and a test for it. BUG=654684 TEST=unit_tests Committed: https://crrev.com/e1c72209b2babf55ccd41247330e2ec18caa85df Cr-Commit-Position: refs/heads/master@{#431425}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Add comments #

Patch Set 3 : Address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -7 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.h View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc View 1 2 3 chunks +23 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util_unittest.cc View 1 2 2 chunks +17 lines, -1 line 0 comments Download
A chrome/browser/chromeos/arc/fileapi/intent_helper_util.h View 1 1 chunk +29 lines, -0 lines 1 comment Download
A chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc View 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
hashimoto
Sorry for spamming you with CLs. Please review these CLs at your convenience. This is ...
4 years, 1 month ago (2016-11-02 08:48:17 UTC) #4
hidehiko
Minor comments only. https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc File chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc (right): https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc#newcode42 chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc:42: GURL FileSystemUrlToArcUrl(const storage::FileSystemURL& url) { Could ...
4 years, 1 month ago (2016-11-04 17:19:50 UTC) #7
hashimoto
PTAL https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc File chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc (right): https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc#newcode42 chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc:42: GURL FileSystemUrlToArcUrl(const storage::FileSystemURL& url) { On 2016/11/04 17:19:49, ...
4 years, 1 month ago (2016-11-07 05:34:16 UTC) #8
hidehiko
https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc File chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc (right): https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc#newcode42 chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc:42: GURL FileSystemUrlToArcUrl(const storage::FileSystemURL& url) { On 2016/11/07 05:34:15, hashimoto ...
4 years, 1 month ago (2016-11-07 18:07:54 UTC) #13
hashimoto
PTAL https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc File chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc (right): https://codereview.chromium.org/2464333003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc#newcode42 chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.cc:42: GURL FileSystemUrlToArcUrl(const storage::FileSystemURL& url) { On 2016/11/07 18:07:54, ...
4 years, 1 month ago (2016-11-08 01:34:16 UTC) #14
hidehiko
lgtm https://codereview.chromium.org/2464333003/diff/40001/chrome/browser/chromeos/arc/fileapi/intent_helper_util.h File chrome/browser/chromeos/arc/fileapi/intent_helper_util.h (right): https://codereview.chromium.org/2464333003/diff/40001/chrome/browser/chromeos/arc/fileapi/intent_helper_util.h#newcode14 chrome/browser/chromeos/arc/fileapi/intent_helper_util.h:14: // Utility which posts a task to run ...
4 years, 1 month ago (2016-11-10 07:10:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464333003/40001
4 years, 1 month ago (2016-11-10 22:27:04 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 00:46:22 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:48:51 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1c72209b2babf55ccd41247330e2ec18caa85df
Cr-Commit-Position: refs/heads/master@{#431425}

Powered by Google App Engine
This is Rietveld 408576698