Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2469243002: arc: Implement ArcContentFileSystemAsyncFileUtil::GetFileInfo (Closed)

Created:
4 years, 1 month ago by hashimoto
Modified:
4 years, 1 month ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Implement ArcContentFileSystemAsyncFileUtil::GetFileInfo BUG=654684 TEST=unit_tests Committed: https://crrev.com/6a0588e6e5569b64f03785920897fda2bea93ec2 Cr-Commit-Position: refs/heads/master@{#431474}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -4 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc View 2 chunks +23 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
hashimoto
Sorry for spamming you with CLs. Please review these CLs at your convenience. This is ...
4 years, 1 month ago (2016-11-02 08:48:36 UTC) #4
hidehiko
lgtm
4 years, 1 month ago (2016-11-04 22:55:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469243002/20001
4 years, 1 month ago (2016-11-11 00:51:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 02:59:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 03:09:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a0588e6e5569b64f03785920897fda2bea93ec2
Cr-Commit-Position: refs/heads/master@{#431474}

Powered by Google App Engine
This is Rietveld 408576698