Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2469163002: Clean up source_site_instance usage in Navigator::RequestOpenURL. (Closed)

Created:
4 years, 1 month ago by alexmos
Modified:
4 years, 1 month ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up source_site_instance usage in Navigator::RequestOpenURL. Passing source_site_instance is unnecessary/redundant now that proxy navigations don't use this, and the only call site is RenderFrameHostImpl::OpenURL, which always passes in the current RFH's SiteInstance. BUG=656752, 647772 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/452ce50129657e65181973f1e49e3c963a445e0a Cr-Commit-Position: refs/heads/master@{#429625}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Charlie's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M content/browser/frame_host/navigator.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +13 lines, -17 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
alexmos
Charlie, can you please take a look? This cleanup is a followup to https://codereview.chromium.org/2454563003/.
4 years, 1 month ago (2016-11-02 00:35:49 UTC) #5
Charlie Reis
Thanks for the cleanup! LGTM with one request for OnOpenURL/OpenURL. https://codereview.chromium.org/2469163002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/2469163002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode764 ...
4 years, 1 month ago (2016-11-02 17:05:37 UTC) #8
alexmos
https://codereview.chromium.org/2469163002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/2469163002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode764 content/browser/frame_host/navigator_impl.cc:764: params.source_site_instance = current_site_instance; On 2016/11/02 17:05:36, Charlie Reis wrote: ...
4 years, 1 month ago (2016-11-03 06:03:01 UTC) #13
Charlie Reis
Thanks! LGTM.
4 years, 1 month ago (2016-11-03 16:58:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469163002/20001
4 years, 1 month ago (2016-11-03 17:00:49 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 17:06:44 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:13:23 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/452ce50129657e65181973f1e49e3c963a445e0a
Cr-Commit-Position: refs/heads/master@{#429625}

Powered by Google App Engine
This is Rietveld 408576698