Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2469163002: Clean up source_site_instance usage in Navigator::RequestOpenURL. (Closed)
Patch Set: Charlie's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 // If a cross-site request is in progress, we may be suspended while waiting 368 // If a cross-site request is in progress, we may be suspended while waiting
369 // for the onbeforeunload handler, so this function might buffer the message 369 // for the onbeforeunload handler, so this function might buffer the message
370 // rather than sending it. 370 // rather than sending it.
371 void Navigate(const CommonNavigationParams& common_params, 371 void Navigate(const CommonNavigationParams& common_params,
372 const StartNavigationParams& start_params, 372 const StartNavigationParams& start_params,
373 const RequestNavigationParams& request_params); 373 const RequestNavigationParams& request_params);
374 374
375 // Navigates to an interstitial page represented by the provided data URL. 375 // Navigates to an interstitial page represented by the provided data URL.
376 void NavigateToInterstitialURL(const GURL& data_url); 376 void NavigateToInterstitialURL(const GURL& data_url);
377 377
378 // Treat this prospective navigation as though it originated from the frame.
379 // Used, e.g., for a navigation request that originated from a RemoteFrame.
380 // |source_site_instance| is the SiteInstance of the frame that initiated the
381 // navigation.
382 // TODO(creis): Remove this method and have RenderFrameProxyHost call
383 // RequestOpenURL with its FrameTreeNode.
384 void OpenURL(const FrameHostMsg_OpenURL_Params& params,
385 SiteInstance* source_site_instance);
386
387 // Stop the load in progress. 378 // Stop the load in progress.
388 void Stop(); 379 void Stop();
389 380
390 // Returns whether navigation messages are currently suspended for this 381 // Returns whether navigation messages are currently suspended for this
391 // RenderFrameHost. Only true during a cross-site navigation, while waiting 382 // RenderFrameHost. Only true during a cross-site navigation, while waiting
392 // for the onbeforeunload handler. 383 // for the onbeforeunload handler.
393 bool are_navigations_suspended() const { return navigations_suspended_; } 384 bool are_navigations_suspended() const { return navigations_suspended_; }
394 385
395 // Suspends (or unsuspends) any navigation messages from being sent from this 386 // Suspends (or unsuspends) any navigation messages from being sent from this
396 // RenderFrameHost. This is called when a pending RenderFrameHost is created 387 // RenderFrameHost. This is called when a pending RenderFrameHost is created
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
1060 remote_associated_interfaces_; 1051 remote_associated_interfaces_;
1061 // NOTE: This must be the last member. 1052 // NOTE: This must be the last member.
1062 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1053 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1063 1054
1064 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1055 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1065 }; 1056 };
1066 1057
1067 } // namespace content 1058 } // namespace content
1068 1059
1069 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1060 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698