Clean up source_site_instance usage in Navigator::RequestOpenURL.

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 695 matching lines @@
   // should "use up" the SiteInstance.
   return GetContentClient()->browser()->ShouldAssignSiteForURL(url);
 }
 
 void NavigatorImpl::RequestOpenURL(
     RenderFrameHostImpl* render_frame_host,
     const GURL& url,
     bool uses_post,
     const scoped_refptr<ResourceRequestBodyImpl>& body,
     const std::string& extra_headers,
-    SiteInstance* source_site_instance,
     const Referrer& referrer,
     WindowOpenDisposition disposition,
     bool should_replace_current_entry,
     bool user_gesture) {
   // Note: This can be called for subframes (even when OOPIFs are not possible)
   // if the disposition calls for a different window.
 
   // Only the current RenderFrameHost should be sending an OpenURL request.
   // Pending RenderFrameHost should know where it is navigating and pending
   // deletion RenderFrameHost shouldn't be trying to navigate.
@@ skipping 28 matching lines @@
     frame_tree_node_id =
         render_frame_host->frame_tree_node()->frame_tree_node_id();
   }
 
   OpenURLParams params(dest_url, referrer, frame_tree_node_id, disposition,
                        ui::PAGE_TRANSITION_LINK,
                        true /* is_renderer_initiated */);
   params.uses_post = uses_post;
   params.post_data = body;
   params.extra_headers = extra_headers;
-  params.source_site_instance = source_site_instance;
+  params.source_site_instance = current_site_instance;

[Charlie Reis, 2016/11/02 17:05:36]

Let's put a comment on this, saying that only same-SiteInstance frames can reach
here, since RequestOpenURL is only used for local frames.  (This matters both if
we ever go back to using RequestOpenURL in RenderFrameProxy, or if we someday
decide to avoid frame tree duplication when multiple SiteInstances share the
same process.)

[alexmos, 2016/11/03 06:03:01]

Done.

   if (redirect_chain.size() > 0)
     params.redirect_chain = redirect_chain;
   params.should_replace_current_entry = should_replace_current_entry;
   params.user_gesture = user_gesture;
 
   if (render_frame_host->web_ui()) {
     // Web UI pages sometimes want to override the page transition type for
     // link clicks (e.g., so the new tab page can specify AUTO_BOOKMARK for
     // automatically generated suggestions).  We don't override other types
     // like TYPED because they have different implications (e.g., autocomplete).
@@ skipping 496 matching lines @@
     if (navigation_handle)
       navigation_handle->update_entry_id_for_transfer(entry->GetUniqueID());
 
     controller_->SetPendingEntry(std::move(entry));
     if (delegate_)
       delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content