Clean up source_site_instance usage in Navigator::RequestOpenURL.

content/browser/frame_host/render_frame_host_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 357 matching lines @@
   // If a cross-site request is in progress, we may be suspended while waiting
   // for the onbeforeunload handler, so this function might buffer the message
   // rather than sending it.
   void Navigate(const CommonNavigationParams& common_params,
                 const StartNavigationParams& start_params,
                 const RequestNavigationParams& request_params);
 
   // Navigates to an interstitial page represented by the provided data URL.
   void NavigateToInterstitialURL(const GURL& data_url);
 
-  // Treat this prospective navigation as though it originated from the frame.
-  // Used, e.g., for a navigation request that originated from a RemoteFrame.
-  // |source_site_instance| is the SiteInstance of the frame that initiated the
-  // navigation.
-  // TODO(creis): Remove this method and have RenderFrameProxyHost call

[Charlie Reis, 2016/11/02 17:05:37]

Interesting-- I guess this evolved to be the default way to get to
RequestOpenURL instead.  Thanks for cleaning up the comment.

[alexmos, 2016/11/03 06:03:01]

Comment is now gone after I combined this with OnOpenURL. :)  Most of it is now
in the comment on setting source_site_instance in RequestOpenURL, but let me
know if there's a better place for it.

-  // RequestOpenURL with its FrameTreeNode.
-  void OpenURL(const FrameHostMsg_OpenURL_Params& params,
-               SiteInstance* source_site_instance);
+  // Starts a new navigation.  This navigation can originate from any frame in
+  // this frame's SiteInstance.  Note that navigations on RenderFrameProxies do
+  // not use this and go through RequestTransferURL instead.
+  void OpenURL(const FrameHostMsg_OpenURL_Params& params);
 
   // Stop the load in progress.
   void Stop();
 
   // Returns whether navigation messages are currently suspended for this
   // RenderFrameHost. Only true during a cross-site navigation, while waiting
   // for the onbeforeunload handler.
   bool are_navigations_suspended() const { return navigations_suspended_; }
 
   // Suspends (or unsuspends) any navigation messages from being sent from this
@@ skipping 664 matching lines @@
       remote_associated_interfaces_;
   // NOTE: This must be the last member.
   base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_