MD Settings: fix chrome.passwordsPrivate empty list bug

MD Settings: fix chrome.passwordsPrivate empty list bug

R=rdevlin.cronin@chromium.org
BUG=657215
Committed: https://crrev.com/80312194b99b0f8b03d0e5c9a3920b81399d6fd6
Cr-Commit-Position: refs/heads/master@{#429148}

[Dan Beam, 2016-10-31 23:41:59]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:42:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:58:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-11-01 00:09:57]

couple of nits and looks like you have a compile error...

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/passwords_private/passwords_private_api.cc
(right):

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/passwords_private/passwords_private_api.cc:102:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
Is this git cl formatted?

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
(right):

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h:46:
using UiEntriesCallback = base::Callback<void(const UiEntries*)>;
Why pass this as a const UiEntries* instead of const UiEntries&?

[Dan Beam, 2016-11-01 21:04:06]

Patchset #4 (id:60001) has been deleted

[Dan Beam, 2016-11-01 21:04:12]

Patchset #3 (id:40001) has been deleted

[Dan Beam, 2016-11-01 21:08:26]

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/passwords_private/passwords_private_api.cc
(right):

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/passwords_private/passwords_private_api.cc:102:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
On 2016/11/01 00:09:57, Devlin wrote:
> Is this git cl formatted?

is now

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
(right):

https://codereview.chromium.org/2468763002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h:46:
using UiEntriesCallback = base::Callback<void(const UiEntries*)>;
On 2016/11/01 00:09:57, Devlin wrote:
> Why pass this as a const UiEntries* instead of const UiEntries&?

Done.

[Dan Beam, 2016-11-01 21:08:30]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 21:09:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-11-01 21:41:36]

lgtm

[commit-bot: I haz the power, 2016-11-01 22:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 22:56:47]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-11-01 22:59:29]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-11-01 22:59:47]

follow up here: https://codereview.chromium.org/2466273004/

[commit-bot: I haz the power, 2016-11-01 23:00:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 23:16:45]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-11-01 23:19:29]

Description was changed from

==========
MD Settings: fix chrome.passwordsPrivate empty list bug

R=rdevlin.cronin@chromium.org
BUG=657215
==========

to

==========
MD Settings: fix chrome.passwordsPrivate empty list bug

R=rdevlin.cronin@chromium.org
BUG=657215

Committed: https://crrev.com/80312194b99b0f8b03d0e5c9a3920b81399d6fd6
Cr-Commit-Position: refs/heads/master@{#429148}
==========

[commit-bot: I haz the power, 2016-11-01 23:19:33]

Patchset 4 (id:??) landed as
https://crrev.com/80312194b99b0f8b03d0e5c9a3920b81399d6fd6
Cr-Commit-Position: refs/heads/master@{#429148}