MD Settings: fix chrome.passwordsPrivate empty list bug

chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_PASSWORDS_PRIVATE_PASSWORDS_PRIVATE_DELEGATE_H_
 #define CHROME_BROWSER_EXTENSIONS_API_PASSWORDS_PRIVATE_PASSWORDS_PRIVATE_DELEGATE_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 24 matching lines @@
 // passwords and password exceptions and to notify listeners when these values
 // have changed.
 class PasswordsPrivateDelegate : public KeyedService {
  public:
   ~PasswordsPrivateDelegate() override {}
 
   // Sends the saved passwords list to the event router.
   virtual void SendSavedPasswordsList() = 0;
 
   // Gets the saved passwords list.
-  virtual const std::vector<api::passwords_private::PasswordUiEntry>*
-  GetSavedPasswordsList() const = 0;
+  using UiEntries = std::vector<api::passwords_private::PasswordUiEntry>;
+  using UiEntriesCallback = base::Callback<void(const UiEntries*)>;

[Devlin, 2016/11/01 00:09:57]

Why pass this as a const UiEntries* instead of const UiEntries&?

[Dan Beam, 2016/11/01 21:08:25]

Done.

+  virtual void GetSavedPasswordsList(const UiEntriesCallback& callback) = 0;
 
   // Sends the password exceptions list to the event router.
   virtual void SendPasswordExceptionsList() = 0;
 
   // Gets the password exceptions list.
-  virtual const std::vector<api::passwords_private::ExceptionPair>*
-  GetPasswordExceptionsList() const = 0;
+  using ExceptionPairs = std::vector<api::passwords_private::ExceptionPair>;
+  using ExceptionPairsCallback = base::Callback<void(const ExceptionPairs*)>;
+  virtual void GetPasswordExceptionsList(
+      const ExceptionPairsCallback& callback) = 0;
 
   // Removes the saved password entry corresponding to |origin_url| and
   // |username|.
   // |origin_url| The human-readable origin for the URL where the password is
   //     used/ should be obtained using GetHumanReadableOrigin().
   // |username| The username used in conjunction with the saved password.
   virtual void RemoveSavedPassword(
       const std::string& origin_url, const std::string& username) = 0;
 
   // Removes the saved password exception entry corresponding to
@@ skipping 10 matching lines @@
   // |native_window| The Chrome host window; will be used to show an OS-level
   //     authentication dialog if necessary.
   virtual void RequestShowPassword(const std::string& origin_url,
                                    const std::string& username,
                                    content::WebContents* web_contents) = 0;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_PASSWORDS_PRIVATE_PASSWORDS_PRIVATE_DELEGATE_H_