Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7839)

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc

Issue 2468763002: MD Settings: fix chrome.passwordsPrivate empty list bug (Closed)
Patch Set: git cl format + compile + const ref + bool rename Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
index 7ec270b1d330c3a7e303fd8ae31fc17711805a05..6ab38ffe1239b855a3749e30661def2a14b119f8 100644
--- a/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
@@ -77,9 +77,8 @@ class TestDelegate : public PasswordsPrivateDelegate {
router->OnSavedPasswordsListChanged(current_entries_);
}
- const std::vector<api::passwords_private::PasswordUiEntry>*
- GetSavedPasswordsList() const override {
- return &current_entries_;
+ void GetSavedPasswordsList(const UiEntriesCallback& callback) override {
+ callback.Run(current_entries_);
}
void SendPasswordExceptionsList() override {
@@ -89,9 +88,9 @@ class TestDelegate : public PasswordsPrivateDelegate {
router->OnPasswordExceptionsListChanged(current_exceptions_);
}
- const std::vector<api::passwords_private::ExceptionPair>*
- GetPasswordExceptionsList() const override {
- return &current_exceptions_;
+ void GetPasswordExceptionsList(
+ const ExceptionPairsCallback& callback) override {
+ callback.Run(current_exceptions_);
}
void RemoveSavedPassword(

Powered by Google App Engine
This is Rietveld 408576698