MD Settings: fix chrome.passwordsPrivate empty list bug

chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/passwords_private/passwords_private_api.h"
 
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/location.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.h"
 #include "chrome/common/extensions/api/passwords_private.h"
 #include "components/password_manager/core/common/experiments.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_function_registry.h"
 
 namespace extensions {
 
 ////////////////////////////////////////////////////////////////////////////////
@@ skipping 69 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordsPrivateGetSavedPasswordListFunction
 
 PasswordsPrivateGetSavedPasswordListFunction::
     ~PasswordsPrivateGetSavedPasswordListFunction() {}
 
 ExtensionFunction::ResponseAction
 PasswordsPrivateGetSavedPasswordListFunction::Run() {
+  // GetList() can immediately call GotList() (which would Respond() before
+  // RespondLater()). So we post a task to preserve order.
+  base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,

[Devlin, 2016/11/01 00:09:57]

Is this git cl formatted?

[Dan Beam, 2016/11/01 21:08:25]

is now

+      base::Bind(&PasswordsPrivateGetSavedPasswordListFunction::GetList, this));
+  return RespondLater();
+}
+
+void PasswordsPrivateGetSavedPasswordListFunction::GetList() {
   PasswordsPrivateDelegate* delegate =
       PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context(),
                                                             true /* create */);
-  return RespondNow(ArgumentList(
-      api::passwords_private::GetSavedPasswordList::Results::Create(
-          *(delegate->GetSavedPasswordsList()))));
+  delegate->GetSavedPasswordsList(
+      base::Bind(&PasswordsPrivateGetSavedPasswordListFunction::GotList, this));
+}
+
+void PasswordsPrivateGetSavedPasswordListFunction::GotList(
+    const PasswordsPrivateDelegate::UiEntries* list) {
+  Respond(ArgumentList(
+      api::passwords_private::GetSavedPasswordList::Results::Create(*list)));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordsPrivateGetPasswordExceptionListFunction
 
 PasswordsPrivateGetPasswordExceptionListFunction::
     ~PasswordsPrivateGetPasswordExceptionListFunction() {}
 
 ExtensionFunction::ResponseAction
 PasswordsPrivateGetPasswordExceptionListFunction::Run() {
+  // GetList() can immediately call GotList() (which would Respond() before
+  // RespondLater()). So we post a task to preserve order.
+  base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+      base::Bind(&PasswordsPrivateGetPasswordExceptionListFunction::GetList,
+                 this));
+  return RespondLater();
+}
+
+void PasswordsPrivateGetPasswordExceptionListFunction::GetList() {
   PasswordsPrivateDelegate* delegate =
       PasswordsPrivateDelegateFactory::GetForBrowserContext(browser_context(),
                                                             true /* create */);
-  return RespondNow(ArgumentList(
+  delegate->GetPasswordExceptionsList(
+      base::Bind(&PasswordsPrivateGetPasswordExceptionListFunction::GotList,
+                 this));
+}
+
+void PasswordsPrivateGetPasswordExceptionListFunction::GotList(
+    const PasswordsPrivateDelegate::ExceptionPairs* list) {
+  Respond(ArgumentList(
       api::passwords_private::GetPasswordExceptionList::Results::Create(
-          *(delegate->GetPasswordExceptionsList()))));
+          *list)));
 }
 
 }  // namespace extensions