Issue 24677002: Revert "Revert "Dartium changes for custom element lifecycle events.""

Issue 24677002: Revert "Revert "Dartium changes for custom element lifecycle events."" (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
vsm

CC:
reviews+dom_dartlang.org, siva

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Revert "Revert "Dartium changes for custom element lifecycle events."" This is an update to https://codereview.chromium.org/24294002/ Primary changes: Added a fast-path for Document.createElement Integrated feedback from https://codereview.chromium.org/23513085/ This is paired with: https://codereview.chromium.org/24491003/ BUG= R=vsm@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1392

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+783 lines, -369 lines)			Patch
D	Source/bindings/dart/DartCustomElement.h	View		1 chunk	+0 lines, -74 lines	0 comments	Download
D	Source/bindings/dart/DartCustomElement.cpp	View		1 chunk	+0 lines, -143 lines	0 comments	Download
A +	Source/bindings/dart/DartCustomElementBinding.h	View	1	1 chunk	+12 lines, -9 lines	0 comments	Download
A +	Source/bindings/dart/DartCustomElementBinding.cpp	View		1 chunk	+8 lines, -5 lines	0 comments	Download
A +	Source/bindings/dart/DartCustomElementConstructorBuilder.h	View		1 chunk	+25 lines, -35 lines	0 comments	Download
A	Source/bindings/dart/DartCustomElementConstructorBuilder.cpp	View		1 chunk	+130 lines, -0 lines	0 comments	Download
A +	Source/bindings/dart/DartCustomElementLifecycleCallbacks.h	View		1 chunk	+14 lines, -21 lines	0 comments	Download
A	Source/bindings/dart/DartCustomElementLifecycleCallbacks.cpp	View		1 chunk	+177 lines, -0 lines	0 comments	Download
A +	Source/bindings/dart/DartCustomElementWrapper.h	View		1 chunk	+16 lines, -11 lines	0 comments	Download
A	Source/bindings/dart/DartCustomElementWrapper.cpp	View	1	1 chunk	+133 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/DartDOMData.h	View		5 chunks	+9 lines, -5 lines	0 comments	Download
M	Source/bindings/dart/DartDOMData.cpp	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/DartDOMWrapper.h	View	1	6 chunks	+13 lines, -16 lines	0 comments	Download
M	Source/bindings/dart/DartDOMWrapper.cpp	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	Source/bindings/dart/DartNativeUtilities.cpp	View	1 2	6 chunks	+82 lines, -21 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.h	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.cpp	View	1 2	4 chunks	+36 lines, -6 lines	0 comments	Download
M	Source/bindings/dart/custom/DartDocumentCustom.cpp	View	1	2 chunks	+86 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/gyp/overrides.gypi	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/dart/gyp/scripts/massage_factories.py	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/bindings/v8/CustomElementConstructorBuilder.h	View		1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/24677002/diff/3001/Source/bindings/dart/DartUtilities.cpp File Source/bindings/dart/DartUtilities.cpp (right): https://codereview.chromium.org/24677002/diff/3001/Source/bindings/dart/DartUtilities.cpp#newcode365 Source/bindings/dart/DartUtilities.cpp:365: bool DartUtilities::objectIsClass(Dart_Handle handle, Dart_Handle cls) I'd call this ...

7 years, 2 months ago (2013-09-25 22:39:10 UTC) #2

blois

https://codereview.chromium.org/24677002/diff/3001/Source/bindings/dart/DartUtilities.cpp File Source/bindings/dart/DartUtilities.cpp (right): https://codereview.chromium.org/24677002/diff/3001/Source/bindings/dart/DartUtilities.cpp#newcode365 Source/bindings/dart/DartUtilities.cpp:365: bool DartUtilities::objectIsClass(Dart_Handle handle, Dart_Handle cls) On 2013/09/25 22:39:10, vsm ...

7 years, 2 months ago (2013-09-25 22:50:18 UTC) #3

blois

7 years, 2 months ago (2013-09-25 23:14:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r1392 (presubmit successful).

Expand Messages | Collapse Messages