Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: Source/bindings/dart/DartCustomElement.cpp

Issue 24677002: Revert "Revert "Dartium changes for custom element lifecycle events."" (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartCustomElement.h ('k') | Source/bindings/dart/DartCustomElementBinding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartCustomElement.cpp
diff --git a/Source/bindings/dart/DartCustomElement.cpp b/Source/bindings/dart/DartCustomElement.cpp
deleted file mode 100644
index 262801e342817929ee29cd9afd801a15cd323789..0000000000000000000000000000000000000000
--- a/Source/bindings/dart/DartCustomElement.cpp
+++ /dev/null
@@ -1,143 +0,0 @@
-// Copyright 2013, Google Inc.
-// All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-// * Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-// * Redistributions in binary form must reproduce the above
-// copyright notice, this list of conditions and the following disclaimer
-// in the documentation and/or other materials provided with the
-// distribution.
-// * Neither the name of Google Inc. nor the names of its
-// contributors may be used to endorse or promote products derived from
-// this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-#include "config.h"
-#include "DartCustomElement.h"
-
-namespace WebCore {
-
-Dart_Handle DartCustomElement::createWrapper(Element* impl, CreateWrapperFunction createWrapper)
-{
- if (!impl)
- return Dart_Null();
-
- HTMLElement* element = reinterpret_cast<HTMLElement*>(impl);
-
- // FIXME: Streamline the common path. If an element is already upgraded properly,
- // we shouldn't need all this checking.
-
- // Look up custom Dart type.
- DartDOMData* domData = DartDOMData::current();
-
- ASSERT(!DartDOMWrapper::lookupWrapper(domData, DartHTMLElement::isNode, element));
-
- String name = element->localName();
- DartCustomElementMap* map = domData->customElementMap();
- Dart_PersistentHandle persistent = map->get(name);
- if (!persistent) {
- // Not a custom tag. Check for type extension.
- if (element->hasAttribute("is")) {
- name = element->getAttribute("is");
- persistent = map->get(name);
- }
-
- // No custom type. Fall back onto builtin wrapper type.
- if (!persistent) {
- return createWrapper.invoke(element);
- }
- }
-
- Dart_Handle type = Dart_HandleFromPersistent(persistent);
- ASSERT(!Dart_IsError(type));
-
- DartCustomElementMap* nativeMap = domData->customBaseElementMap();
- Dart_Handle expectedNativeType = Dart_HandleFromPersistent(nativeMap->get(name));
- ASSERT(!Dart_IsError(expectedNativeType));
-
- // FIXME: Avoid allocating the fallback wrapper until we know we need it.
- Dart_Handle fallback = createWrapper.invoke(element);
- Dart_Handle actualNativeType = Dart_InstanceGetType(fallback);
- ASSERT(!Dart_IsError(actualNativeType));
-
- if (!Dart_IdentityEquals(actualNativeType, expectedNativeType)) {
- // The registered custom type does not match. Just fallback.
- return fallback;
- }
- DartDOMWrapper::disassociateWrapper<DartHTMLElement>(element, fallback);
-
- Dart_Handle newInstance = Dart_Allocate(type);
- ASSERT(!Dart_IsError(newInstance));
-
- Dart_Handle result = Dart_SetNativeInstanceField(newInstance, 0, reinterpret_cast<intptr_t>(element));
- UNUSED_PARAM(result);
- ASSERT(!Dart_IsError(result));
-
- DartDOMWrapper::associateWrapper<DartHTMLElement>(element, newInstance);
- Dart_Invoke(newInstance, Dart_NewStringFromCString("created"), 0, 0);
- return newInstance;
-}
-
-Dart_WeakPersistentHandle DartCustomElement::lookupWrapper(
- DartDOMData* domData, Dart_WeakPersistentHandle wrapper, Element* impl)
-{
- ASSERT(impl);
- ASSERT(wrapper);
-
- HTMLElement* element = reinterpret_cast<HTMLElement*>(impl);
-
- // FIXME: Streamline the common path. If an element is already upgraded properly,
- // we shouldn't need all this checking.
-
- // Look up custom Dart type.
- String name = element->localName();
- DartCustomElementMap* map = domData->customElementMap();
- Dart_PersistentHandle persistent = map->get(name);
- if (!persistent) {
- // Not a custom tag. Check for type extension.
- if (element->hasAttribute("is")) {
- name = element->getAttribute("is");
- persistent = map->get(name);
- }
-
- // No custom type. Fall back onto builtin wrapper type.
- if (!persistent) {
- return wrapper;
- }
- }
- // Previous wrapper exists. Test for upgrade.
- Dart_Handle type = Dart_HandleFromPersistent(persistent);
- Dart_Handle oldInstance = Dart_HandleFromWeakPersistent(wrapper);
- Dart_Handle oldType = Dart_InstanceGetType(oldInstance);
- ASSERT(!Dart_IsError(oldType));
- if (Dart_IdentityEquals(oldType, type))
- return wrapper;
-
- DartCustomElementMap* nativeMap = domData->customBaseElementMap();
- Dart_Handle expectedNativeType = Dart_HandleFromPersistent(nativeMap->get(name));
- ASSERT(!Dart_IsError(expectedNativeType));
-
- if (!Dart_IdentityEquals(oldType, expectedNativeType)) {
- // The registered custom type does not match. Just fallback.
- return wrapper;
- }
-
- return 0;
-}
-
-} // namespace WebCore
« no previous file with comments | « Source/bindings/dart/DartCustomElement.h ('k') | Source/bindings/dart/DartCustomElementBinding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698