[builtins]: Uniformly push argument count in TF-generated builtins

[builtins]: Uniformly push argument count in TF-generated builtins

Committed: https://crrev.com/4447405b179db63748c10d8cb3d139e795195eb3
Cr-Commit-Position: refs/heads/master@{#40712}

[danno, 2016-10-31 15:44:58]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 15:45:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 15:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:46:20]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15449)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15478)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/15413)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11733)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27592)

[danno, 2016-10-31 16:12:19]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:12:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:17:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[danno, 2016-10-31 16:31:29]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:31:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-10-31 16:59:28]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:59:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-10-31 17:29:47]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org

[danno, 2016-10-31 17:29:48]

PTAL

[commit-bot: I haz the power, 2016-10-31 17:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:51:36]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Benedikt Meurer, 2016-11-02 08:57:22]

lgtm

[danno, 2016-11-03 02:06:38]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 02:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:35:33]

Dry run: This issue passed the CQ dry run.

[danno, 2016-11-03 02:43:14]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 02:43:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-11-03 02:50:06]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 02:50:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-11-03 02:50:34]

please take another look, I had to reorganize and cleanup some stuff to get
ARM64 to work.

[commit-bot: I haz the power, 2016-11-03 03:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 03:27:22]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-11-03 05:00:04]

LGTM once comment addressed.

https://codereview.chromium.org/2467513002/diff/160001/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):

https://codereview.chromium.org/2467513002/diff/160001/src/compiler/linkage.c...
src/compiler/linkage.cc:111: if (IsJSFunctionCall()) {
Please turn this into a switch over the call descriptor kind instead of this
nested ifs plus some tenary magic at the end.

[danno, 2016-11-03 07:51:27]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 07:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-11-03 07:55:38]

Feedback addressed, landing.

https://codereview.chromium.org/2467513002/diff/160001/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):

https://codereview.chromium.org/2467513002/diff/160001/src/compiler/linkage.c...
src/compiler/linkage.cc:111: if (IsJSFunctionCall()) {
On 2016/11/03 05:00:03, Benedikt Meurer wrote:
> Please turn this into a switch over the call descriptor kind instead of this
> nested ifs plus some tenary magic at the end.

Done.

[commit-bot: I haz the power, 2016-11-03 07:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:55:43]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[danno, 2016-11-03 08:01:26]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 08:01:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:25:55]

Dry run: This issue passed the CQ dry run.

[danno, 2016-11-03 08:33:55]

The CQ bit was checked by danno@chromium.org

[danno, 2016-11-03 08:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2467513002/#ps200001
(title: "Fix windows build")

[commit-bot: I haz the power, 2016-11-03 08:34:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:36:11]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-11-17 22:19:56]

Description was changed from

==========
[builtins]: Uniformly push argument count in TF-generated builtins
==========

to

==========
[builtins]: Uniformly push argument count in TF-generated builtins

Committed: https://crrev.com/4447405b179db63748c10d8cb3d139e795195eb3
Cr-Commit-Position: refs/heads/master@{#40712}
==========

[commit-bot: I haz the power, 2016-11-17 22:19:57]

Patchset 11 (id:??) landed as
https://crrev.com/4447405b179db63748c10d8cb3d139e795195eb3
Cr-Commit-Position: refs/heads/master@{#40712}