Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: src/compiler/linkage.h

Issue 2467513002: [builtins]: Uniformly push argument count in TF-generated builtins (Closed)
Patch Set: Fix windows build Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/linkage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/linkage.h
diff --git a/src/compiler/linkage.h b/src/compiler/linkage.h
index 0ecf64530ef966e4ff8a95365bb60a1c7c17ebc2..b515aca2da785d182ed941584ac04ee53b6933e1 100644
--- a/src/compiler/linkage.h
+++ b/src/compiler/linkage.h
@@ -187,7 +187,9 @@ class V8_EXPORT_PRIVATE CallDescriptor final
// Causes the code generator to initialize the root register.
kInitializeRootRegister = 1u << 7,
// Does not ever try to allocate space on our heap.
- kNoAllocate = 1u << 8
+ kNoAllocate = 1u << 8,
+ // Push argument count as part of function prologue.
+ kPushArgumentCount = 1u << 9
};
typedef base::Flags<Flag> Flags;
@@ -249,6 +251,7 @@ class V8_EXPORT_PRIVATE CallDescriptor final
bool NeedsFrameState() const { return flags() & kNeedsFrameState; }
bool SupportsTailCalls() const { return flags() & kSupportsTailCalls; }
bool UseNativeStack() const { return flags() & kUseNativeStack; }
+ bool PushArgumentCount() const { return flags() & kPushArgumentCount; }
bool InitializeRootRegister() const {
return flags() & kInitializeRootRegister;
}
@@ -296,6 +299,8 @@ class V8_EXPORT_PRIVATE CallDescriptor final
bool CanTailCall(const Node* call) const;
+ int CalculateFixedFrameSize() const;
+
private:
friend class Linkage;
« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/linkage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698