Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: src/compiler/pipeline.cc

Issue 2467513002: [builtins]: Uniformly push argument count in TF-generated builtins (Closed)
Patch Set: Fix windows build Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index f05ccfa8a8e6afff2a8f61825e54fdf6ad905170..5e3bfceb08e9a9961e9ba1cf475e9371c7d9032b 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -283,7 +283,7 @@ class PipelineData {
DCHECK(frame_ == nullptr);
int fixed_frame_size = 0;
if (descriptor != nullptr) {
- fixed_frame_size = CalculateFixedFrameSize(descriptor);
+ fixed_frame_size = descriptor->CalculateFixedFrameSize();
}
frame_ = new (instruction_zone()) Frame(fixed_frame_size);
}
@@ -355,16 +355,6 @@ class PipelineData {
// Source position output for --trace-turbo.
std::string source_position_output_;
- int CalculateFixedFrameSize(CallDescriptor* descriptor) {
- if (descriptor->IsJSFunctionCall()) {
- return StandardFrameConstants::kFixedSlotCount;
- }
- return descriptor->IsCFunctionCall()
- ? (CommonFrameConstants::kFixedSlotCountAboveFp +
- CommonFrameConstants::kCPSlotCount)
- : TypedFrameConstants::kFixedSlotCount;
- }
-
DISALLOW_COPY_AND_ASSIGN(PipelineData);
};
« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698