[builtins]: Uniformly push argument count in TF-generated builtins

src/compiler/linkage.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/linkage.h"
 
 #include "src/ast/scopes.h"
 #include "src/builtins/builtins-utils.h"
 #include "src/code-stubs.h"
 #include "src/compilation-info.h"
@@ skipping 89 matching lines @@
       }
     }
   }
   return callee_slots_above_sp - tail_caller_slots_above_sp;
 }
 
 bool CallDescriptor::CanTailCall(const Node* node) const {
   return HasSameReturnLocationsAs(CallDescriptorOf(node->op()));
 }
 
+int CallDescriptor::CalculateFixedFrameSize() const {
+  if (IsJSFunctionCall()) {

[Benedikt Meurer, 2016/11/03 05:00:03]

Please turn this into a switch over the call descriptor kind instead of this
nested ifs plus some tenary magic at the end.

[danno, 2016/11/03 07:55:38]

Done.

+    if (PushArgumentCount()) {
+      return OptimizedBuiltinFrameConstants::kFixedSlotCount;
+    } else {
+      return StandardFrameConstants::kFixedSlotCount;
+    }
+  }
+  return IsCFunctionCall() ? (CommonFrameConstants::kFixedSlotCountAboveFp +
+                              CommonFrameConstants::kCPSlotCount)
+                           : TypedFrameConstants::kFixedSlotCount;
+}
 
 CallDescriptor* Linkage::ComputeIncoming(Zone* zone, CompilationInfo* info) {
   DCHECK(!info->IsStub());
   if (!info->closure().is_null()) {
     // If we are compiling a JS function, use a JS call descriptor,
     // plus the receiver.
     SharedFunctionInfo* shared = info->closure()->shared();
     return GetJSCallDescriptor(zone, info->is_osr(),
                                1 + shared->internal_formal_parameter_count(),
                                CallDescriptor::kNoFlags);
@@ skipping 370 matching lines @@
     DCHECK(loc == regloc(kContextRegister, MachineType::AnyTagged()));
     return LinkageLocation::ForCalleeFrameSlot(Frame::kContextSlot,
                                                MachineType::AnyTagged());
   }
 }
 
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8