Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2467203002: Remove fullscreen content settings UI from Android. (Closed)

Created:
4 years, 1 month ago by Matt Giuca
Modified:
4 years, 1 month ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fullscreen content settings UI from Android. This UI was vestigial since the content settings themselves had been removed and data deleted. This just cleans up non-functional UI, both the general setting in Site Settings, and the per-site setting on the site page. BUG=591896 Committed: https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa Cr-Commit-Position: refs/heads/master@{#429474}

Patch Set 1 #

Patch Set 2 : Delete images and strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
D chrome/android/java/res/drawable-hdpi/permission_fullscreen.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/permission_fullscreen.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/permission_fullscreen.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/permission_fullscreen.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/permission_fullscreen.png View 1 Binary file 0 comments Download
M chrome/android/java/res/xml/single_website_preferences.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/res/xml/site_settings_preferences.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 7 chunks +0 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java View 5 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Matt Giuca
Part of removing Fullscreen content settings from Chrome. finnur@chromium.org: Please review changes in *.java files. ...
4 years, 1 month ago (2016-11-02 03:21:59 UTC) #2
Finnur
> mailto:finnur@chromium.org: Please review changes in *.java files. LGTM > Note: This leaves behind a ...
4 years, 1 month ago (2016-11-02 16:45:03 UTC) #9
David Trainor- moved to gerrit
lgtm. Keeping them together would be fine with me as well.
4 years, 1 month ago (2016-11-02 17:46:35 UTC) #10
Matt Giuca
On 2016/11/02 17:46:35, David Trainor (OOO to oct 31) wrote: > lgtm. Keeping them together ...
4 years, 1 month ago (2016-11-03 00:17:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467203002/20001
4 years, 1 month ago (2016-11-03 00:18:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 00:25:02 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 00:27:57 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa
Cr-Commit-Position: refs/heads/master@{#429474}

Powered by Google App Engine
This is Rietveld 408576698