Remove fullscreen content settings UI from Android.

Remove fullscreen content settings UI from Android.

This UI was vestigial since the content settings themselves had been
removed and data deleted. This just cleans up non-functional UI, both
the general setting in Site Settings, and the per-site setting on the
site page.

BUG=591896
Committed: https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa
Cr-Commit-Position: refs/heads/master@{#429474}

[Matt Giuca, 2016-11-02 03:21:58]

mgiuca@chromium.org changed reviewers:
+ dtrainor@chromium.org, finnur@chromium.org

[Matt Giuca, 2016-11-02 03:21:59]

Part of removing Fullscreen content settings from Chrome.

finnur@chromium.org: Please review changes in *.java files.

dtrainor@chromium.org: Please review changes in *.xml and *.grd files.

Note: This leaves behind a bunch of dead code which I will clean up in
https://codereview.chromium.org/2470043002. Let me know if you think it would be
better for me to just merge that into this one.

[Matt Giuca, 2016-11-02 03:27:53]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 03:28:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2016-11-02 03:44:20]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 03:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 04:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 04:13:42]

Dry run: This issue passed the CQ dry run.

[Finnur, 2016-11-02 16:45:03]

> mailto:finnur@chromium.org: Please review changes in *.java files.

LGTM

> Note: This leaves behind a bunch of dead code which I will clean up in
> https://codereview.chromium.org/2470043002. Let me know if you think it would
be
> better for me to just merge that into this one.

It feels more natural to me to keep it all together. I've reviewed patch set 1
of the other CL as well, and that also LGTM (if you want to merge them). I don't
feel strongly though, so I'll leave it up to you.

[David Trainor- moved to gerrit, 2016-11-02 17:46:35]

lgtm.  Keeping them together would be fine with me as well.

[Matt Giuca, 2016-11-03 00:17:53]

On 2016/11/02 17:46:35, David Trainor (OOO to oct 31) wrote:
> lgtm.  Keeping them together would be fine with me as well.

Thanks. Since I have all the necessary LGTMs on both, I'll just keep them
separate. If it makes you feel any better, they are fairly cleanly split among
removing the settings UI (this CL) versus removal of the underlying usage of the
permissions system for fullscreen (other CL). It isn't just "get it working" and
"clean up".

[Matt Giuca, 2016-11-03 00:17:59]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-11-03 00:18:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 00:25:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 00:27:56]

Description was changed from

==========
Remove fullscreen content settings UI from Android.

This UI was vestigial since the content settings themselves had been
removed and data deleted. This just cleans up non-functional UI, both
the general setting in Site Settings, and the per-site setting on the
site page.

BUG=591896
==========

to

==========
Remove fullscreen content settings UI from Android.

This UI was vestigial since the content settings themselves had been
removed and data deleted. This just cleans up non-functional UI, both
the general setting in Site Settings, and the per-site setting on the
site page.

BUG=591896

Committed: https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa
Cr-Commit-Position: refs/heads/master@{#429474}
==========

[commit-bot: I haz the power, 2016-11-03 00:27:57]

Patchset 2 (id:??) landed as
https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa
Cr-Commit-Position: refs/heads/master@{#429474}