Issue 2470043002: Android: Clean up dead code involving now-removed Fullscreen permission.

Issue 2470043002: Android: Clean up dead code involving now-removed Fullscreen permission. (Closed)

Created:
4 years, 1 month ago by Matt Giuca

Modified:
4 years, 1 month ago

Reviewers:
David Trainor- moved to gerrit

CC:
chromium-reviews, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Android: Clean up dead code involving now-removed Fullscreen permission. BUG=591896 Committed: https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157 Cr-Commit-Position: refs/heads/master@{#429525}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -210 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java	View	4 chunks	+0 lines, -26 lines	0 comments	Download
D	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/FullscreenInfo.java	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java	View	5 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java	View	2 chunks	+0 lines, -35 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java	View	3 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/android/java_sources.gni	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/android/preferences/pref_service_bridge.cc	View	2 chunks	+0 lines, -29 lines	0 comments	Download
M	chrome/browser/android/preferences/website_preference_bridge.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download

Depends on Patchset:

Total messages: 8 (3 generated)

Matt Giuca

Hi David, Following up on https://codereview.chromium.org/2467203002.

4 years, 1 month ago (2016-11-02 03:24:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470043002/1

4 years, 1 month ago (2016-11-03 00:32:22 UTC) #5

commit-bot: I haz the power

4 years, 1 month ago (2016-11-03 04:33:01 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157
Cr-Commit-Position: refs/heads/master@{#429525}