Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

Issue 2467203002: Remove fullscreen content settings UI from Android. (Closed)
Patch Set: Delete images and strings. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
index 981c9866661702c1979dbeb95566df617fcea1c7..edad2354ef327539f6ed3196c05d72ee09c6728a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
@@ -72,7 +72,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
public static final String PREF_BACKGROUND_SYNC_PERMISSION = "background_sync_permission_list";
public static final String PREF_CAMERA_CAPTURE_PERMISSION = "camera_permission_list";
public static final String PREF_COOKIES_PERMISSION = "cookies_permission_list";
- public static final String PREF_FULLSCREEN_PERMISSION = "fullscreen_permission_list";
public static final String PREF_JAVASCRIPT_PERMISSION = "javascript_permission_list";
public static final String PREF_KEYGEN_PERMISSION = "keygen_permission_list";
public static final String PREF_LOCATION_ACCESS = "location_access_list";
@@ -90,7 +89,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
PREF_BACKGROUND_SYNC_PERMISSION,
PREF_CAMERA_CAPTURE_PERMISSION,
PREF_COOKIES_PERMISSION,
- PREF_FULLSCREEN_PERMISSION,
PREF_JAVASCRIPT_PERMISSION,
PREF_KEYGEN_PERMISSION,
PREF_LOCATION_ACCESS,
@@ -202,10 +200,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
// This loop looks expensive, but the amount of data is likely to be relatively small
// because most sites have very few permissions.
for (Website other : websites) {
- if (merged.getFullscreenInfo() == null && other.getFullscreenInfo() != null
- && permissionInfoIsForTopLevelOrigin(other.getFullscreenInfo(), origin)) {
- merged.setFullscreenInfo(other.getFullscreenInfo());
- }
if (merged.getGeolocationInfo() == null && other.getGeolocationInfo() != null
&& permissionInfoIsForTopLevelOrigin(other.getGeolocationInfo(), origin)) {
merged.setGeolocationInfo(other.getGeolocationInfo());
@@ -308,9 +302,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
setUpListPreference(preference, mSite.getCameraPermission());
} else if (PREF_COOKIES_PERMISSION.equals(preference.getKey())) {
setUpListPreference(preference, mSite.getCookiePermission());
- } else if (PREF_FULLSCREEN_PERMISSION.equals(preference.getKey())) {
- preference.setEnabled(false);
- setUpListPreference(preference, mSite.getFullscreenPermission());
} else if (PREF_JAVASCRIPT_PERMISSION.equals(preference.getKey())) {
setUpListPreference(preference, mSite.getJavaScriptPermission());
} else if (PREF_KEYGEN_PERMISSION.equals(preference.getKey())) {
@@ -544,8 +535,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
return ContentSettingsType.CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA;
case PREF_COOKIES_PERMISSION:
return ContentSettingsType.CONTENT_SETTINGS_TYPE_COOKIES;
- case PREF_FULLSCREEN_PERMISSION:
- return ContentSettingsType.CONTENT_SETTINGS_TYPE_FULLSCREEN;
case PREF_JAVASCRIPT_PERMISSION:
return ContentSettingsType.CONTENT_SETTINGS_TYPE_JAVASCRIPT;
case PREF_KEYGEN_PERMISSION:
@@ -608,8 +597,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
mSite.setCameraPermission(permission);
} else if (PREF_COOKIES_PERMISSION.equals(preference.getKey())) {
mSite.setCookiePermission(permission);
- } else if (PREF_FULLSCREEN_PERMISSION.equals(preference.getKey())) {
- mSite.setFullscreenPermission(permission);
} else if (PREF_JAVASCRIPT_PERMISSION.equals(preference.getKey())) {
mSite.setJavaScriptPermission(permission);
} else if (PREF_KEYGEN_PERMISSION.equals(preference.getKey())) {
@@ -687,7 +674,6 @@ public class SingleWebsitePreferences extends PreferenceFragment
mSite.setCameraPermission(ContentSetting.DEFAULT);
mSite.setCookiePermission(ContentSetting.DEFAULT);
WebsitePreferenceBridge.nativeClearCookieData(mSite.getAddress().getTitle());
- mSite.setFullscreenPermission(ContentSetting.DEFAULT);
mSite.setGeolocationPermission(ContentSetting.DEFAULT);
mSite.setJavaScriptPermission(ContentSetting.DEFAULT);
mSite.setKeygenPermission(ContentSetting.DEFAULT);

Powered by Google App Engine
This is Rietveld 408576698