Disallow [ Missing ] expectations in test expectations files.

Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations should probably be handled generating/fetching new baselines, or adding NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in layout_tests/port/test.py.

BUG=661215, 591500
Committed: https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5
Cr-Commit-Position: refs/heads/master@{#429326}

[qyearsley, 2016-11-01 18:30:09]

Description was changed from

==========
Disallow [ Missing ] expectations in test expectations files.

BUG=661215
==========

to

==========
Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations
should probably be handled generating/fetching new baselines, or adding
NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in
layout_tests/port/test.py.

BUG=661215
==========

[qyearsley, 2016-11-01 18:30:10]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, ojan@chromium.org

[qyearsley, 2016-11-01 18:30:56]

Does this seem like a good idea? Also, if so, should I send a short PSA email to
blink-dev?

[Dirk Pranke, 2016-11-01 19:09:34]

lgtm.

Yes, I think this is probably a good idea at this point.

https://codereview.chromium.org/2467013002/diff/20001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
(right):

https://codereview.chromium.org/2467013002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:221:
print one_line_summary
I'm guessing you forgot to delete this?

[qyearsley, 2016-11-01 21:55:27]

https://codereview.chromium.org/2467013002/diff/20001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
(right):

https://codereview.chromium.org/2467013002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:221:
print one_line_summary
On 2016/11/01 at 19:09:34, Dirk Pranke wrote:
> I'm guessing you forgot to delete this?

Yep :-/ Now removed.

[qyearsley, 2016-11-01 21:55:31]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 21:56:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 23:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 23:06:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-11-02 16:17:23]

Description was changed from

==========
Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations
should probably be handled generating/fetching new baselines, or adding
NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in
layout_tests/port/test.py.

BUG=661215
==========

to

==========
Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations
should probably be handled generating/fetching new baselines, or adding
NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in
layout_tests/port/test.py.

BUG=661215,591500
==========

[qyearsley, 2016-11-02 16:17:30]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 16:17:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:28:24]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-11-02 17:34:28]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-11-02 17:34:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2467013002/#ps60001
(title: "Change current missing expectations to skips")

[commit-bot: I haz the power, 2016-11-02 17:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:40:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-02 17:56:42]

Description was changed from

==========
Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations
should probably be handled generating/fetching new baselines, or adding
NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in
layout_tests/port/test.py.

BUG=661215,591500
==========

to

==========
Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations
should probably be handled generating/fetching new baselines, or adding
NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in
layout_tests/port/test.py.

BUG=661215,591500

Committed: https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5
Cr-Commit-Position: refs/heads/master@{#429326}
==========

[commit-bot: I haz the power, 2016-11-02 17:56:43]

Patchset 4 (id:??) landed as
https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5
Cr-Commit-Position: refs/heads/master@{#429326}