third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py - Issue 2467013002: Disallow [ Missing ] expectations in test expectations files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

Issue 2467013002: Disallow [ Missing ] expectations in test expectations files. (Closed)

Patch Set: Change current missing expectations to skips Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright (C) 2010 Google Inc. All rights reserved.	1 # Copyright (C) 2010 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91	91

92 def test_valid_expectations(self):	92 def test_valid_expectations(self):

93 self.assert_lines_lint(["crbug.com/1234 [ Mac ] passes/text.html [ Pass Failure ]"], should_pass=True)	93 self.assert_lines_lint(["crbug.com/1234 [ Mac ] passes/text.html [ Pass Failure ]"], should_pass=True)

94	94

95 def test_invalid_expectations(self):	95 def test_invalid_expectations(self):

96 self.assert_lines_lint(["Bug(me) passes/text.html [ Give Up]"], should_p ass=False)	96 self.assert_lines_lint(["Bug(me) passes/text.html [ Give Up]"], should_p ass=False)

97	97

98 def test_tab(self):	98 def test_tab(self):

99 self.assert_lines_lint(["\twebkit.org/b/1 passes/text.html [ Pass ]"], s hould_pass=False,	99 self.assert_lines_lint(["\twebkit.org/b/1 passes/text.html [ Pass ]"], s hould_pass=False,

100 expected_output="Line contains tab character. [w hitespace/tab] [5]")	100 expected_output="Line contains tab character. [w hitespace/tab] [5]")

	101

	102 def test_missing_expectation_not_allowed(self):

	103 self.assert_lines_lint(["crbug.com/1234 [ Mac ] passes/text.html [ Missi ng ]"], should_pass=False)

OLD	NEW