third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py - Issue 2467013002: Disallow [ Missing ] expectations in test expectations files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py

Issue 2467013002: Disallow [ Missing ] expectations in test expectations files. (Closed)

Patch Set: Change current missing expectations to skips Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py

index 02404d45f005ee480960a8fb487cd9e144bc321b..534fcf414045b7e85588654c9639a7ccd3bc6fac 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py

@@ -184,12 +184,6 @@ class MockDRTTest(unittest.TestCase):

def test_checksum_in_png(self):

self.assertTest('passes/checksum_in_image.html', True)

- def test_missing_image(self):

- self.assertTest('failures/expected/missing_image.html', True)

- def test_missing_text(self):

- self.assertTest('failures/expected/missing_text.html', True)

def test_reftest_match(self):

self.assertTest('passes/reftest.html', True, expected_checksum='mock-checksum', expected_text='reference text\n')