third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py - Issue 2467013002: Disallow [ Missing ] expectations in test expectations files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

Issue 2467013002: Disallow [ Missing ] expectations in test expectations files. (Closed)

Patch Set: Change current missing expectations to skips Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

index ed388eeb4d15cbad08c8e4f023af4418c0d14cee..c5ff9e5cb4198135dee94e803d7f7d3fbbbf49a6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

@@ -98,3 +98,6 @@ class TestExpectationsTestCase(unittest.TestCase):

def test_tab(self):

self.assert_lines_lint(["\twebkit.org/b/1 passes/text.html [ Pass ]"], should_pass=False,

expected_output="Line contains tab character. [whitespace/tab] [5]")

+ def test_missing_expectation_not_allowed(self):

+ self.assert_lines_lint(["crbug.com/1234 [ Mac ] passes/text.html [ Missing ]"], should_pass=False)

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py ('k') | no next file » | no next file with comments »