Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2465963002: Reland "gpu, cmaa: reduce one-copy", "gpu, cmaa: copy RGBA8 texture via glCopyTexSubImage2D() inste… (Closed)

Created:
4 years, 1 month ago by dshwang
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "gpu, cmaa: reduce one-copy", "gpu, cmaa: copy RGBA8 texture via glCopyTexSubImage2D() instead of imageStore()." Original CL: https://codereview.chromium.org/2298613010 : use glCopyTexSubImage2D, and fix Pri1 bug https://codereview.chromium.org/2405893002 : optimize further Revert CL: https://codereview.chromium.org/2456913002 : glCopyTexSubImage2D regresses performance and optimization CL is reverted due to conflict. Changes: - fix Pri1 bug as-is - optimize further as-is - don't introduce glCopyTexSubImage2D, and use the existing copy shader. BUG=535198, 642290, 659438 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6cd0a67f8256ecb9e0fb899528bdffc74f0e7042 Cr-Commit-Position: refs/heads/master@{#428826}

Patch Set 1 #

Patch Set 2 : diff to original CLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -125 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 1 31 chunks +93 lines, -116 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dshwang
piman, could you review to reland reverted Pri1 bug fix. crbug.com/642290 https://codereview.chromium.org/2456913002 reverts two CLs ...
4 years, 1 month ago (2016-10-31 17:31:34 UTC) #7
piman
lgtm
4 years, 1 month ago (2016-10-31 21:13:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465963002/20001
4 years, 1 month ago (2016-10-31 21:18:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 21:38:14 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 21:40:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cd0a67f8256ecb9e0fb899528bdffc74f0e7042
Cr-Commit-Position: refs/heads/master@{#428826}

Powered by Google App Engine
This is Rietveld 408576698