Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2456913002: Revert "gpu, cmaa: copy RGBA8 texture via glCopyTexSubImage2D() instead of imageStore()." (Closed)

Created:
4 years, 1 month ago by marcheu1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "gpu, cmaa: copy RGBA8 texture via glCopyTexSubImage2D() instead of imageStore()." This reverts commit b2d7e66345c253f353d1d3c555964f6e95e26b9c. This change kills webgl performance. BUG=chromium:659438 TEST=build and run on cyan, check that performance is back Revert "gpu, cmaa: reduce one-copy" This reverts commit 2058173d586111ff8b4d19ddf5cb53fc6a3233ca. This change kills webgl performance. BUG=chromium:659438 TEST=build and run on cyan, check that performance is back CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6589f37045b3dbd94ec4a3245d2313dc9a7cd427 Cr-Commit-Position: refs/heads/master@{#428581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -100 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h View 3 chunks +11 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 31 chunks +137 lines, -91 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
marcheu1
4 years, 1 month ago (2016-10-28 22:24:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456913002/1
4 years, 1 month ago (2016-10-28 22:24:56 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-28 22:24:58 UTC) #8
piman
lgtm
4 years, 1 month ago (2016-10-28 23:26:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456913002/1
4 years, 1 month ago (2016-10-28 23:51:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 01:41:40 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 01:43:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6589f37045b3dbd94ec4a3245d2313dc9a7cd427
Cr-Commit-Position: refs/heads/master@{#428581}

Powered by Google App Engine
This is Rietveld 408576698