Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2463453002: "Fix" remaining connection error handlers in Blink (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, awdf+watch_chromium.org, rouslan+payments_chromium.org, Peter Beverloo, tzik, nhiroki, kinuko+fileapi, blink-reviews, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

"Fix" remaining connection error handlers in Blink This changes all remaining Mojo connection error handlers in Blink to no-op if invoked after Blink shutdown. TBRing haraken@ since this solution has already been discussed and landed in several other cases, and it's a P0. BUG=658907 TBR=haraken@chromium.org Committed: https://crrev.com/d84779e26d4783df207dd66e9b7f6f5f3878c026 Cr-Commit-Position: refs/heads/master@{#428468}

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463453002/1
4 years, 1 month ago (2016-10-28 18:21:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 20:09:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d84779e26d4783df207dd66e9b7f6f5f3878c026 Cr-Commit-Position: refs/heads/master@{#428468}
4 years, 1 month ago (2016-10-28 20:13:07 UTC) #8
haraken
4 years, 1 month ago (2016-10-28 20:28:30 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698