Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

Issue 2463453002: "Fix" remaining connection error handlers in Blink (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/notifications/NotificationManager.h" 5 #include "modules/notifications/NotificationManager.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "modules/notifications/Notification.h" 9 #include "modules/notifications/Notification.h"
10 #include "modules/notifications/NotificationPermissionCallback.h" 10 #include "modules/notifications/NotificationPermissionCallback.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 NotificationPermissionCallback* deprecatedCallback, 97 NotificationPermissionCallback* deprecatedCallback,
98 mojom::blink::PermissionStatus status) { 98 mojom::blink::PermissionStatus status) {
99 String statusString = Notification::permissionString(status); 99 String statusString = Notification::permissionString(status);
100 if (deprecatedCallback) 100 if (deprecatedCallback)
101 deprecatedCallback->handleEvent(statusString); 101 deprecatedCallback->handleEvent(statusString);
102 102
103 resolver->resolve(statusString); 103 resolver->resolve(statusString);
104 } 104 }
105 105
106 void NotificationManager::onPermissionServiceConnectionError() { 106 void NotificationManager::onPermissionServiceConnectionError() {
107 if (!Platform::current()) {
108 // TODO(rockot): Clean this up once renderer shutdown sequence is fixed.
109 return;
110 }
107 m_permissionService.reset(); 111 m_permissionService.reset();
108 } 112 }
109 113
110 DEFINE_TRACE(NotificationManager) { 114 DEFINE_TRACE(NotificationManager) {
111 ContextLifecycleObserver::trace(visitor); 115 ContextLifecycleObserver::trace(visitor);
112 Supplement<ExecutionContext>::trace(visitor); 116 Supplement<ExecutionContext>::trace(visitor);
113 } 117 }
114 118
115 } // namespace blink 119 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698