Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp

Issue 2463453002: "Fix" remaining connection error handlers in Blink (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp b/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
index 3645dda02520e92b144f4b51d847c53dc31fc139..5039dbab7b6c718112a0ef01d3ed814a7f104de9 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
+++ b/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
@@ -7,6 +7,7 @@
#include "modules/sensor/SensorProxy.h"
#include "platform/mojo/MojoHelper.h"
#include "public/platform/InterfaceProvider.h"
+#include "public/platform/Platform.h"
namespace blink {
@@ -55,6 +56,11 @@ SensorProxy* SensorProviderProxy::getOrCreateSensor(
}
void SensorProviderProxy::onSensorProviderConnectionError() {
+ if (!Platform::current()) {
+ // TODO(rockot): Clean this up once renderer shutdown sequence is fixed.
+ return;
+ }
+
m_sensorProvider.reset();
for (SensorProxy* sensor : m_sensors)
sensor->handleSensorError();

Powered by Google App Engine
This is Rietveld 408576698