third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp - Issue 2463453002: "Fix" remaining connection error handlers in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

Issue 2463453002: "Fix" remaining connection error handlers in Blink (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

diff --git a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

index fdc669c2ab98df6b9e01cab11e6f541d129d302b..9004c723161b167cd11df69f7b0d89d12728d651 100644

--- a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

+++ b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

@@ -127,6 +127,11 @@ ScriptPromise NavigatorShare::share(ScriptState* scriptState,

}

void NavigatorShare::onConnectionError() {

+ if (!Platform::current()) {

+ // TODO(rockot): Clean this up once renderer shutdown sequence is fixed.

+ return;

+ }

for (auto& client : m_clients) {

client->onConnectionError();

}