INPUT element: code cleanup

INPUT element: code cleanup

* Rename HTMLInputElement::m_valueIfDirty to m_nonAttributeValue.
  Now it stores non-dirty values.

* Rename InputType::defaultValue() to defaultLabel(), valueWithDefault() to
valueOrDefaultLabel()
  |defaultValue| was confused with |defaultValue| IDL attribute. InputType::
defaultValue() represented a default button label for type=reset and type=submit.

* Remove InputType::fallbackValue()
  There were no external call sites.

* Rename InputType::getTypeSpecificValue() to valueInFilenameValueMode(), and
makes it returning String.
  It is used only for ValueMode::kFilename.

This CL has no behavior changes.

Committed: https://crrev.com/cc82e2a1fabccacaa65873f96041126bbcd88671
Cr-Commit-Position: refs/heads/master@{#428909}

[tkent, 2016-10-31 08:10:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 08:11:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 09:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 09:18:41]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-10-31 21:57:22]

Description was changed from

==========
INPUT element: code cleanup

BUG=
==========

to

==========
INPUT element: code cleanup

* Rename HTMLInputElement::m_valueIfDirty to m_nonAttributeValue.
  Now it stores non-dirty values.

* Rename InputType::defaultValue() to defaultLabel(), valueWithDefault() to
valueOrDefaultLabel()
  |defaultValue| was confused with |defaultValue| IDL attribute. InputType::
defaultValue() represented a default button label for type=reset and
type=submit.

* Remove InputType::fallbackValue()
  There were no external call sites.

* Rename InputType::getTypeSpecificValue() to valueInFilenameValueMode(), and
makes it returning String.
  It is used only for ValueMode::kFilename.

This CL has no behavior changes.
==========

[tkent, 2016-10-31 21:57:57]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-10-31 21:57:58]

Keishi, would you review this trivial CL please?

[keishi, 2016-11-01 01:28:36]

LGTM

[tkent, 2016-11-01 01:47:26]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:53:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-01 01:55:16]

Description was changed from

==========
INPUT element: code cleanup

* Rename HTMLInputElement::m_valueIfDirty to m_nonAttributeValue.
  Now it stores non-dirty values.

* Rename InputType::defaultValue() to defaultLabel(), valueWithDefault() to
valueOrDefaultLabel()
  |defaultValue| was confused with |defaultValue| IDL attribute. InputType::
defaultValue() represented a default button label for type=reset and
type=submit.

* Remove InputType::fallbackValue()
  There were no external call sites.

* Rename InputType::getTypeSpecificValue() to valueInFilenameValueMode(), and
makes it returning String.
  It is used only for ValueMode::kFilename.

This CL has no behavior changes.
==========

to

==========
INPUT element: code cleanup

* Rename HTMLInputElement::m_valueIfDirty to m_nonAttributeValue.
  Now it stores non-dirty values.

* Rename InputType::defaultValue() to defaultLabel(), valueWithDefault() to
valueOrDefaultLabel()
  |defaultValue| was confused with |defaultValue| IDL attribute. InputType::
defaultValue() represented a default button label for type=reset and
type=submit.

* Remove InputType::fallbackValue()
  There were no external call sites.

* Rename InputType::getTypeSpecificValue() to valueInFilenameValueMode(), and
makes it returning String.
  It is used only for ValueMode::kFilename.

This CL has no behavior changes.

Committed: https://crrev.com/cc82e2a1fabccacaa65873f96041126bbcd88671
Cr-Commit-Position: refs/heads/master@{#428909}
==========

[commit-bot: I haz the power, 2016-11-01 01:55:16]

Patchset 1 (id:??) landed as
https://crrev.com/cc82e2a1fabccacaa65873f96041126bbcd88671
Cr-Commit-Position: refs/heads/master@{#428909}