Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2462983002: INPUT element: code cleanup (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 void setEditingValue(const String&); 143 void setEditingValue(const String&);
144 144
145 double valueAsDate(bool& isNull) const; 145 double valueAsDate(bool& isNull) const;
146 void setValueAsDate(double, ExceptionState&); 146 void setValueAsDate(double, ExceptionState&);
147 147
148 double valueAsNumber() const; 148 double valueAsNumber() const;
149 void setValueAsNumber(double, 149 void setValueAsNumber(double,
150 ExceptionState&, 150 ExceptionState&,
151 TextFieldEventBehavior = DispatchNoEvent); 151 TextFieldEventBehavior = DispatchNoEvent);
152 152
153 String valueWithDefault() const; 153 String valueOrDefaultLabel() const;
154 154
155 // This function dispatches 'input' event for non-textfield types. Callers 155 // This function dispatches 'input' event for non-textfield types. Callers
156 // need to handle any DOM structure changes by event handlers, or need to 156 // need to handle any DOM structure changes by event handlers, or need to
157 // delay the 'input' event with EventQueueScope. 157 // delay the 'input' event with EventQueueScope.
158 void setValueFromRenderer(const String&); 158 void setValueFromRenderer(const String&);
159 159
160 int selectionStartForBinding(ExceptionState&) const; 160 int selectionStartForBinding(ExceptionState&) const;
161 int selectionEndForBinding(ExceptionState&) const; 161 int selectionEndForBinding(ExceptionState&) const;
162 String selectionDirectionForBinding(ExceptionState&) const; 162 String selectionDirectionForBinding(ExceptionState&) const;
163 void setSelectionStartForBinding(int, ExceptionState&); 163 void setSelectionStartForBinding(int, ExceptionState&);
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 // Returns null if this isn't associated with any radio button group. 401 // Returns null if this isn't associated with any radio button group.
402 RadioButtonGroupScope* radioButtonGroupScope() const; 402 RadioButtonGroupScope* radioButtonGroupScope() const;
403 void addToRadioButtonGroup(); 403 void addToRadioButtonGroup();
404 void removeFromRadioButtonGroup(); 404 void removeFromRadioButtonGroup();
405 PassRefPtr<ComputedStyle> customStyleForLayoutObject() override; 405 PassRefPtr<ComputedStyle> customStyleForLayoutObject() override;
406 406
407 bool shouldDispatchFormControlChangeEvent(String&, String&) override; 407 bool shouldDispatchFormControlChangeEvent(String&, String&) override;
408 408
409 AtomicString m_name; 409 AtomicString m_name;
410 // The value string in |value| value mode. 410 // The value string in |value| value mode.
411 // TODO(tkent): Rename it to m_nonAttributeValue. 411 String m_nonAttributeValue;
412 String m_valueIfDirty;
413 String m_suggestedValue; 412 String m_suggestedValue;
414 int m_size; 413 int m_size;
415 int m_maxLength; 414 int m_maxLength;
416 int m_minLength; 415 int m_minLength;
417 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-value-dirty -flag 416 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-value-dirty -flag
418 unsigned m_hasDirtyValue : 1; 417 unsigned m_hasDirtyValue : 1;
419 // https://html.spec.whatwg.org/multipage/forms.html#concept-fe-checked 418 // https://html.spec.whatwg.org/multipage/forms.html#concept-fe-checked
420 unsigned m_isChecked : 1; 419 unsigned m_isChecked : 1;
421 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-checked-dir ty-flag 420 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-checked-dir ty-flag
422 unsigned m_dirtyCheckedness : 1; 421 unsigned m_dirtyCheckedness : 1;
(...skipping 14 matching lines...) Expand all
437 // assumes that it lives as long as its owning element lives. If we move the 436 // assumes that it lives as long as its owning element lives. If we move the
438 // loader into the ImageInput object we may delete the loader while this 437 // loader into the ImageInput object we may delete the loader while this
439 // element lives on. 438 // element lives on.
440 Member<HTMLImageLoader> m_imageLoader; 439 Member<HTMLImageLoader> m_imageLoader;
441 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver; 440 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver;
442 }; 441 };
443 442
444 } // namespace blink 443 } // namespace blink
445 444
446 #endif // HTMLInputElement_h 445 #endif // HTMLInputElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698