Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.h

Issue 2462983002: INPUT element: code cleanup (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/InputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/InputType.h b/third_party/WebKit/Source/core/html/forms/InputType.h
index ca1b864eae91e10f782cdfb541a4ae6c7f768a6e..2dceb74c33911e712632aeca644e73ac7aa4a5f5 100644
--- a/third_party/WebKit/Source/core/html/forms/InputType.h
+++ b/third_party/WebKit/Source/core/html/forms/InputType.h
@@ -88,12 +88,10 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {
// DOM property functions
// Returns a string value in ValueMode::kFilename.
- virtual bool getTypeSpecificValue(String&);
- // TODO(tkent): Remove fallbackValue().
- virtual String fallbackValue() const;
- // Checked after even fallbackValue, only when the valueWithDefault function
- // is called.
- virtual String defaultValue() const;
+ virtual String valueInFilenameValueMode() const;
+ // Default string to be used for showing button and form submission if |value|
+ // is missing.
+ virtual String defaultLabel() const;
// https://html.spec.whatwg.org/multipage/forms.html#dom-input-value
enum class ValueMode { kValue, kDefault, kDefaultOn, kFilename };
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/FileInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698