third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp - Issue 2462983002: INPUT element: code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

Issue 2462983002: INPUT element: code cleanup (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

index 269a0b18bc4df868e86644187aee5dc0a49599a7..99f7960b16e25a8fd892b5448e6d9d13077d7009 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

@@ -67,7 +67,7 @@ void BaseButtonInputType::valueAttributeChanged() {

}

String BaseButtonInputType::displayValue() const {

- return element().valueWithDefault().removeCharacters(isHTMLLineBreak);

+ return element().valueOrDefaultLabel().removeCharacters(isHTMLLineBreak);

}

bool BaseButtonInputType::shouldSaveAndRestoreFormControlState() const {