Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2231)

Unified Diff: chrome/browser/permissions/permission_dialog_delegate.cc

Issue 2462963002: Implement modal permission prompts for media permissions on Android. (Closed)
Patch Set: Nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_dialog_delegate.cc
diff --git a/chrome/browser/permissions/permission_dialog_delegate.cc b/chrome/browser/permissions/permission_dialog_delegate.cc
index c570d755add5b900de2caa487ce4cdbcf065493e..091d7d2ae379ee5fe49852ef5dbc7ff73e20176f 100644
--- a/chrome/browser/permissions/permission_dialog_delegate.cc
+++ b/chrome/browser/permissions/permission_dialog_delegate.cc
@@ -14,7 +14,10 @@
#include "chrome/browser/geolocation/geolocation_infobar_delegate_android.h"
#include "chrome/browser/media/midi_permission_infobar_delegate_android.h"
#include "chrome/browser/media/protected_media_identifier_infobar_delegate_android.h"
+#include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
+#include "chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h"
#include "chrome/browser/notifications/notification_permission_infobar_delegate.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_features.h"
#include "components/variations/variations_associated_data.h"
#include "content/public/browser/android/content_view_core.h"
@@ -51,6 +54,20 @@ void PermissionDialogDelegate::Create(
}
// static
+void PermissionDialogDelegate::CreateMediaStreamDialog(
+ content::WebContents* web_contents,
+ std::unique_ptr<MediaStreamDevicesController> controller) {
+ // Called this way because the infobar delegate has a private destructor.
+ std::unique_ptr<PermissionInfoBarDelegate> infobar_delegate;
+ infobar_delegate.reset(new MediaStreamInfoBarDelegateAndroid(
+ Profile::FromBrowserContext(web_contents->GetBrowserContext()),
+ std::move(controller)));
+
+ // Dispatch the dialog to Java, which manages the lifetime of this object.
+ new PermissionDialogDelegate(web_contents, std::move(infobar_delegate));
+}
+
+// static
bool PermissionDialogDelegate::ShouldShowDialog(bool has_user_gesture) {
if (!base::FeatureList::IsEnabled(features::kModalPermissionPrompts))
return false;
« no previous file with comments | « chrome/browser/permissions/permission_dialog_delegate.h ('k') | content/test/data/android/media_permissions.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698