Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc

Issue 2462963002: Implement modal permission prompts for media permissions on Android. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/webrtc/permission_bubble_media_access_handler.h" 5 #include "chrome/browser/media/webrtc/permission_bubble_media_access_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "chrome/browser/media/webrtc/media_permission.h" 10 #include "chrome/browser/media/webrtc/media_permission.h"
11 #include "chrome/browser/media/webrtc/media_stream_device_permissions.h" 11 #include "chrome/browser/media/webrtc/media_stream_device_permissions.h"
12 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h" 12 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/common/features.h" 14 #include "chrome/common/features.h"
15 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
16 #include "components/content_settings/core/browser/host_content_settings_map.h" 16 #include "components/content_settings/core/browser/host_content_settings_map.h"
17 #include "content/public/browser/browser_thread.h" 17 #include "content/public/browser/browser_thread.h"
18 #include "content/public/browser/notification_service.h" 18 #include "content/public/browser/notification_service.h"
19 #include "content/public/browser/notification_types.h" 19 #include "content/public/browser/notification_types.h"
20 #include "content/public/browser/web_contents.h" 20 #include "content/public/browser/web_contents.h"
21 21
22 #if BUILDFLAG(ANDROID_JAVA_UI) 22 #if BUILDFLAG(ANDROID_JAVA_UI)
23 #include <vector> 23 #include <vector>
24 24
25 #include "base/bind.h" 25 #include "base/bind.h"
26 #include "base/bind_helpers.h" 26 #include "base/bind_helpers.h"
27 #include "chrome/browser/android/chrome_feature_list.h" 27 #include "chrome/browser/android/chrome_feature_list.h"
28 #include "chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h" 28 #include "chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h"
29 #include "chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.h" 29 #include "chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.h"
30 #include "chrome/browser/permissions/permission_dialog_delegate.h"
30 #include "chrome/browser/permissions/permission_update_infobar_delegate_android. h" 31 #include "chrome/browser/permissions/permission_update_infobar_delegate_android. h"
31 #else 32 #else
32 #include "chrome/browser/permissions/permission_request_manager.h" 33 #include "chrome/browser/permissions/permission_request_manager.h"
33 #endif // BUILDFLAG(ANDROID_JAVA_UI) 34 #endif // BUILDFLAG(ANDROID_JAVA_UI)
34 35
35 #if BUILDFLAG(ANDROID_JAVA_UI) 36 #if BUILDFLAG(ANDROID_JAVA_UI)
36 namespace { 37 namespace {
37 // Callback for the permission update infobar when the site and Chrome 38 // Callback for the permission update infobar when the site and Chrome
38 // permissions are mismatched on Android. 39 // permissions are mismatched on Android.
39 void OnPermissionConflictResolved( 40 void OnPermissionConflictResolved(
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 PermissionUpdateInfoBarDelegate::Create( 185 PermissionUpdateInfoBarDelegate::Create(
185 web_contents, content_settings_types, 186 web_contents, content_settings_types,
186 base::Bind( 187 base::Bind(
187 &OnPermissionConflictResolved, base::Passed(&controller))); 188 &OnPermissionConflictResolved, base::Passed(&controller)));
188 } 189 }
189 #endif 190 #endif
190 return; 191 return;
191 } 192 }
192 193
193 #if BUILDFLAG(ANDROID_JAVA_UI) 194 #if BUILDFLAG(ANDROID_JAVA_UI)
194 MediaStreamInfoBarDelegateAndroid::Create(web_contents, 195 if (PermissionDialogDelegate::ShouldShowDialog(request.user_gesture)) {
195 std::move(controller)); 196 PermissionDialogDelegate::CreateMediaStreamDialog(web_contents,
raymes 2016/11/02 08:09:04 Hmm - there seems to be some logic in MediaStreamI
dominickn 2016/11/03 00:34:09 I don't think it's possible for anything except a
197 std::move(controller));
198 } else {
199 MediaStreamInfoBarDelegateAndroid::Create(web_contents,
200 std::move(controller));
201 }
196 #else 202 #else
197 PermissionRequestManager* permission_request_manager = 203 PermissionRequestManager* permission_request_manager =
198 PermissionRequestManager::FromWebContents(web_contents); 204 PermissionRequestManager::FromWebContents(web_contents);
199 if (permission_request_manager) 205 if (permission_request_manager)
200 permission_request_manager->AddRequest(controller.release()); 206 permission_request_manager->AddRequest(controller.release());
201 #endif 207 #endif
202 } 208 }
203 209
204 void PermissionBubbleMediaAccessHandler::UpdateMediaRequestState( 210 void PermissionBubbleMediaAccessHandler::UpdateMediaRequestState(
205 int render_process_id, 211 int render_process_id,
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 272
267 void PermissionBubbleMediaAccessHandler::Observe( 273 void PermissionBubbleMediaAccessHandler::Observe(
268 int type, 274 int type,
269 const content::NotificationSource& source, 275 const content::NotificationSource& source,
270 const content::NotificationDetails& details) { 276 const content::NotificationDetails& details) {
271 DCHECK_CURRENTLY_ON(BrowserThread::UI); 277 DCHECK_CURRENTLY_ON(BrowserThread::UI);
272 DCHECK_EQ(content::NOTIFICATION_WEB_CONTENTS_DESTROYED, type); 278 DCHECK_EQ(content::NOTIFICATION_WEB_CONTENTS_DESTROYED, type);
273 279
274 pending_requests_.erase(content::Source<content::WebContents>(source).ptr()); 280 pending_requests_.erase(content::Source<content::WebContents>(source).ptr());
275 } 281 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698