Enable connection to Mojo services from Blink

Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that binds the connection to the
ServiceManager.
(2) Builds a bare-bones ServiceConnector around this connection that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Committed: https://crrev.com/32fc16c8f8cf5cba4a7bec4f6a18fcbdf32c5e3b
Cr-Original-Commit-Position: refs/heads/master@{#439498}
Cr-Commit-Position: refs/heads/master@{#440419}

[blundell, 2016-10-27 23:09:51]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:10:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:21:52]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[blundell, 2016-10-27 23:32:43]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:33:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 00:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:27:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[blundell, 2016-10-28 20:52:03]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 20:52:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:34:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-10-28 23:00:28]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 23:00:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:22:27]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-10-28 23:36:11]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 23:36:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 01:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 01:31:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-10-31 23:35:33]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:36:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:37:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-11-01 23:50:48]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 23:51:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 02:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 02:15:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[blundell, 2016-11-07 12:29:54]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 12:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 13:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 13:55:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-11-08 10:06:04]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 10:06:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 10:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 10:17:39]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[blundell, 2016-11-08 10:36:07]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 10:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 12:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 12:28:25]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-11-08 14:18:22]

blundell@chromium.org changed reviewers:
+ rockot@chromium.org

[blundell, 2016-11-08 14:18:23]

Ken,

Could you look over the whole CL? Thanks!

[Ken Rockot(use gerrit already), 2016-11-08 18:53:44]

LGTM

I feel a weird about a time zone interface being in the device service. I would
anticipate having a more general system time service (which on e.g. Chrome OS
would be more than just time zone monitoring, as it could presumably also
control the clock-related settings). But that's not a blocking issue and this
seems acceptable for now.

[haraken, 2016-11-08 23:56:58]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-11-08 23:56:59]

https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/time_zone_monitor/DEPS (right):

https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/time_zone_monitor/DEPS:5:
"+services/service_manager/public/cpp/connector.h",

I think it's better to reach consensus on this -- whether it's okay for core/
and modules/ to depend on header files in //services/. Shall we discuss on
platform-architecture-dev@?

[blundell, 2016-11-09 11:53:43]

On 2016/11/08 18:53:44, Ken Rockot wrote:
> LGTM
> 
> I feel a weird about a time zone interface being in the device service. I
would
> anticipate having a more general system time service (which on e.g. Chrome OS
> would be more than just time zone monitoring, as it could presumably also
> control the clock-related settings). But that's not a blocking issue and this
> seems acceptable for now.

Agreed on all counts.

[blundell, 2016-11-09 11:54:42]

https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/time_zone_monitor/DEPS (right):

https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/time_zone_monitor/DEPS:5:
"+services/service_manager/public/cpp/connector.h",
On 2016/11/08 23:56:59, haraken wrote:
> 
> I think it's better to reach consensus on this -- whether it's okay for core/
> and modules/ to depend on header files in //services/. Shall we discuss on
> platform-architecture-dev@?
> 

Yeah, I totally agree. I had done the bulk of the work on this CL before
becoming aware of that issue. I'll start that conversation.

[Ken Rockot(use gerrit already), 2016-11-22 02:18:59]

On 2016/11/09 at 11:54:42, blundell wrote:
>
https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/time_zone_monitor/DEPS (right):
> 
>
https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/time_zone_monitor/DEPS:5:
"+services/service_manager/public/cpp/connector.h",
> On 2016/11/08 23:56:59, haraken wrote:
> > 
> > I think it's better to reach consensus on this -- whether it's okay for
core/
> > and modules/ to depend on header files in //services/. Shall we discuss on
> > platform-architecture-dev@?
> > 
> 
> Yeah, I totally agree. I had done the bulk of the work on this CL before
becoming aware of that issue. I'll start that conversation.

Any progress on consensus here? My opinion is that
//services/service_manager/public/{interfaces,cpp} (which we have tight control
over) should be allowed essentially anywhere, and the same should go for
services/{whatever}/public/interfaces since they are by definition meant to be
public service interfaces. Is there any argument against this limited set of
constraints?

[blundell, 2016-11-22 16:32:53]

On 2016/11/22 02:18:59, Ken Rockot wrote:
> On 2016/11/09 at 11:54:42, blundell wrote:
> >
>
https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/modules/time_zone_monitor/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/2460723003/diff/220001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/modules/time_zone_monitor/DEPS:5:
> "+services/service_manager/public/cpp/connector.h",
> > On 2016/11/08 23:56:59, haraken wrote:
> > > 
> > > I think it's better to reach consensus on this -- whether it's okay for
> core/
> > > and modules/ to depend on header files in //services/. Shall we discuss on
> > > platform-architecture-dev@?
> > > 
> > 
> > Yeah, I totally agree. I had done the bulk of the work on this CL before
> becoming aware of that issue. I'll start that conversation.
> 
> Any progress on consensus here? My opinion is that
> //services/service_manager/public/{interfaces,cpp} (which we have tight
control
> over) should be allowed essentially anywhere, and the same should go for
> services/{whatever}/public/interfaces since they are by definition meant to be
> public service interfaces. Is there any argument against this limited set of
> constraints?

The first part of your statement (re: //service/service_manager/public/cpp) is
indeed under debate. Please give your input on the chromium-mojo@ email thread
that I just sent :), which will hopefully allow us to move forward here one way
or another.

[blundell, 2016-11-28 11:11:34]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 11:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 11:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 11:14:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[blundell, 2016-11-28 12:03:14]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 12:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 12:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 12:05:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[blundell, 2016-11-28 12:08:55]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 12:09:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 12:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 12:29:52]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[blundell, 2016-11-28 15:35:11]

Description was changed from

==========
Move TimeZoneMonitor into the Device Service

This CL moves TimeZoneMonitor from being hosted directly by
RenderProcessHostImpl to being hosted by the Device Service.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

[blundell, 2016-11-28 15:37:21]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 15:37:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-11-28 15:47:57]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

[blundell, 2016-11-28 16:23:15]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

[commit-bot: I haz the power, 2016-11-28 17:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 17:06:30]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-11-28 20:24:01]

Looks nice, just one comment

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
content/child/blink_platform_impl.cc:815: BlinkPlatformImpl::serviceConnector()
{
nit: maybe it should be called createServiceConnector() since serviceConnector()
reads like an accessor and this is actually giving the caller their own new
connector pipe.

Although I also suspect we'll eventually want a helper that lets you get a
connector from any thread. In that case, this API would be more flexible if it
were:

void
BlinkPlatformImpl::bindServiceConnector(service_manager::mojom::blink::ConnectorRequest
request).

Then GetProxy can be called from any thread and the resulting request can be
bounced to this API on the main thread.

[esprehn, 2016-12-02 02:23:13]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-12-02 02:23:15]

lgtm w/ nits fixed.

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
content/child/blink_platform_impl.cc:822: ->GetServiceManagerConnection()
Is there a reason we can't just return the GetServiceManagerConnection() into
blink and then do the GetProxy() inside blink on the correct type to start
instead of rebinding like below?

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/ServiceConnector.h (right):

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:24: void
ConnectToInterface(const char* serviceName,
These should all be lowerCase() for now.

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:49: void
InitializeIfNecessary() {
initializeIfNeeded()

[blundell, 2016-12-05 17:06:02]

Thanks! Currently working through issues related to Device Service lifetime that
this CL happened to expose (see the chromium-mojo@ thread I just posted if
interested).

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
content/child/blink_platform_impl.cc:822: ->GetServiceManagerConnection()
On 2016/12/02 02:23:14, esprehn wrote:
> Is there a reason we can't just return the GetServiceManagerConnection() into
> blink and then do the GetProxy() inside blink on the correct type to start
> instead of rebinding like below?

ServiceManagerConnection is a //content type that wraps the Chromium mojom
interfaces (e.g., ServiceManagerConnection::GetConnector() returns a
service_manager::mojom::ConnectorPtr).

[Ken Rockot(use gerrit already), 2016-12-05 20:54:18]

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/ServiceConnector.h (right):

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
nit: 2016

[haraken, 2016-12-06 00:00:05]

LGTM

[Noel Gordon, 2016-12-07 07:09:25]

noel@chromium.org changed reviewers:
+ noel@chromium.org

[Noel Gordon, 2016-12-07 07:09:26]

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/ServiceConnector.h (right):

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:25:
mojo::InterfaceRequest<Interface> interfacePtr) {
|interfacePtr| ??  Isn't the argument a request?  Maybe we should call it a
request?

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:47: ServiceConnector() :
m_initialized(false) {}
Is this needed? Could we init the class fully at construction-time?

[blundell, 2016-12-08 14:47:06]

Hey Noel,

Thanks for your comments! I'm delaying picking back up on this CL until I
resolve the issues described in the below email, but I'll address your comments
when I do.

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/41Bhbnk6CY0

[blundell, 2016-12-15 15:16:46]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 15:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-12-15 17:04:52]

Thanks! Ken, could you take a final look over the CL?

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/2460723003/diff/300001/content/child/blink_pl...
content/child/blink_platform_impl.cc:815: BlinkPlatformImpl::serviceConnector()
{
On 2016/11/28 20:24:01, Ken Rockot wrote:
> nit: maybe it should be called createServiceConnector() since
serviceConnector()
> reads like an accessor and this is actually giving the caller their own new
> connector pipe.
> 
> Although I also suspect we'll eventually want a helper that lets you get a
> connector from any thread. In that case, this API would be more flexible if it
> were:
> 
> void
>
BlinkPlatformImpl::bindServiceConnector(service_manager::mojom::blink::ConnectorRequest
> request).
> 
> Then GetProxy can be called from any thread and the resulting request can be
> bounced to this API on the main thread.

Done (changed to bindServiceConnector).

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/ServiceConnector.h (right):

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/12/05 20:54:18, Ken Rockot wrote:
> nit: 2016

Done. Hopefully this lands before it needs to be changed again :).

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:24: void
ConnectToInterface(const char* serviceName,
On 2016/12/02 02:23:14, esprehn wrote:
> These should all be lowerCase() for now.

Done.

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:25:
mojo::InterfaceRequest<Interface> interfacePtr) {
On 2016/12/07 07:09:26, noel gordon wrote:
> |interfacePtr| ??  Isn't the argument a request?  Maybe we should call it a
> request?

Great catch, thanks. Done.

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:47: ServiceConnector() :
m_initialized(false) {}
On 2016/12/07 07:09:26, noel gordon wrote:
> Is this needed? Could we init the class fully at construction-time?

The recommended practice in Mojo is to set up all connections on-demand. That
said, with rockot@'s suggested refactoring this becomes simpler and the need for
a distinct InitializeIfNecessary() method goes away.

https://codereview.chromium.org/2460723003/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/ServiceConnector.h:49: void
InitializeIfNecessary() {
On 2016/12/02 02:23:14, esprehn wrote:
> initializeIfNeeded()

Done.

[commit-bot: I haz the power, 2016-12-15 17:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:09:47]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-12-16 14:13:23]

blundell@chromium.org changed reviewers:
+ dcheng@chromium.org, jochen@chromium.org

[blundell, 2016-12-16 14:13:25]

jochen@: Can you review //content/browser?

dcheng@: Can review //content/public/app/mojo?

Thanks!

[jochen (gone - plz use gerrit), 2016-12-19 10:58:18]

content/browser lgtm

[dcheng, 2016-12-19 11:13:21]

mojom and mojo manifest lgtm

https://codereview.chromium.org/2460723003/diff/340001/content/child/blink_pl...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/2460723003/diff/340001/content/child/blink_pl...
content/child/blink_platform_impl.cc:796: if (!ChildThreadImpl::current())
Is this a 'null in unit tests' type thing?

[blundell, 2016-12-19 12:22:25]

Thanks, everyone!

Ken, I'm going to land this based on your earlier LGTM / "looks nice" reviews.

[blundell, 2016-12-19 12:23:04]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-12-19 12:23:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
haraken@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2460723003/#ps340001
(title: "Response to reviews")

[commit-bot: I haz the power, 2016-12-19 12:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 12:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 12:24:58]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[blundell, 2016-12-19 15:05:31]

https://codereview.chromium.org/2460723003/diff/340001/content/child/blink_pl...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/2460723003/diff/340001/content/child/blink_pl...
content/child/blink_platform_impl.cc:796: if (!ChildThreadImpl::current())
On 2016/12/19 11:13:21, dcheng wrote:
> Is this a 'null in unit tests' type thing?

I confess that I cargo-culted this from BlinkPlatformImpl::InternalInit() based
on the comment there ("may not exist in some tests"). I didn't actually verify
that.

[blundell, 2016-12-19 15:13:54]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-12-19 15:13:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jochen@chromium.org, esprehn@chromium.org, dcheng@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2460723003/#ps360001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-19 15:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 17:37:33]

CQ is committing da patch.

Bot data: {"patchset_id": 360001, "attempt_start_ts": 1482160434991550,
"parent_rev": "94622e751956eb876eeecb909e860db6a8444757", "commit_rev":
"209e652d58d8a825eb3f89a0a631c42569a461b9"}

[commit-bot: I haz the power, 2016-12-19 17:38:04]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Review-Url: https://codereview.chromium.org/2460723003
==========

[commit-bot: I haz the power, 2016-12-19 17:38:06]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2016-12-19 17:41:40]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Review-Url: https://codereview.chromium.org/2460723003
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
==========

[commit-bot: I haz the power, 2016-12-19 17:41:42]

Patchset 19 (id:??) landed as
https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}

[jam, 2016-12-19 18:28:41]

A revert of this CL (patchset #19 id:360001) has been created in
https://codereview.chromium.org/2589493006/ by jam@chromium.org.

The reason for reverting is: Caused some build failures, looks like missing
dependencies?

https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds...

FAILED: obj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC
@obj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj.rsp /c
../../third_party/WebKit/Source/platform/heap/ThreadState.cpp
/Foobj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj
/Fd"obj/third_party/WebKit/Source/platform/heap/heap_cc.pdb"
e:\b\c\b\win\src\third_party\webkit\public\platform\platform.h(59): fatal error
C1083: Cannot open include file:
'services/service_manager/public/interfaces/connector.mojom-blink.h': No such
file or directory
.

[Sam McNally, 2016-12-20 07:29:37]

sammc@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2016-12-20 07:29:38]

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/Platform.h (right):

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
third_party/WebKit/public/platform/Platform.h:59: #include
"services/service_manager/public/interfaces/connector.mojom-blink.h"
We shouldn't exposing blink-variant mojoms outside blink.

[blundell, 2016-12-20 07:39:43]

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/Platform.h (right):

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
third_party/WebKit/public/platform/Platform.h:59: #include
"services/service_manager/public/interfaces/connector.mojom-blink.h"
On 2016/12/20 07:29:38, Sam McNally wrote:
> We shouldn't exposing blink-variant mojoms outside blink.

Can you elaborate? I understand that in general, the Blink variants are for
usage strictly within Blink. This exposure is that so that the embedder can give
Blink its service connection. I can do this via an untyped handle, but just
curious on what the exact reasoning is in this case.

[Sam McNally, 2016-12-20 08:57:18]

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/Platform.h (right):

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
third_party/WebKit/public/platform/Platform.h:59: #include
"services/service_manager/public/interfaces/connector.mojom-blink.h"
On 2016/12/20 07:39:43, blundell wrote:
> On 2016/12/20 07:29:38, Sam McNally wrote:
> > We shouldn't exposing blink-variant mojoms outside blink.
> 
> Can you elaborate? I understand that in general, the Blink variants are for
> usage strictly within Blink. This exposure is that so that the embedder can
give
> Blink its service connection. I can do this via an untyped handle, but just
> curious on what the exact reasoning is in this case.

Blink variants of mojoms include WTF types. Using them in blink public
interfaces leaks them into the rest of the codebase. See
https://bugs.chromium.org/p/chromium/issues/detail?id=621177 for another case
where this occurred.

[blundell, 2016-12-20 09:01:57]

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/Platform.h (right):

https://codereview.chromium.org/2460723003/diff/360001/third_party/WebKit/pub...
third_party/WebKit/public/platform/Platform.h:59: #include
"services/service_manager/public/interfaces/connector.mojom-blink.h"
On 2016/12/20 08:57:18, Sam McNally wrote:
> On 2016/12/20 07:39:43, blundell wrote:
> > On 2016/12/20 07:29:38, Sam McNally wrote:
> > > We shouldn't exposing blink-variant mojoms outside blink.
> > 
> > Can you elaborate? I understand that in general, the Blink variants are for
> > usage strictly within Blink. This exposure is that so that the embedder can
> give
> > Blink its service connection. I can do this via an untyped handle, but just
> > curious on what the exact reasoning is in this case.
> 
> Blink variants of mojoms include WTF types. Using them in blink public
> interfaces leaks them into the rest of the codebase. See
> https://bugs.chromium.org/p/chromium/issues/detail?id=621177 for another case
> where this occurred.

Got it, thanks. In making this change, I'll also be able to reland this CL :).

[blundell, 2016-12-20 10:31:55]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
==========

[blundell, 2016-12-20 11:13:28]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 11:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 12:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 12:13:04]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[blundell, 2016-12-20 15:15:40]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 15:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-12-20 16:09:32]

Hi Elliott,

Could you have a look over the (small) diff between PS20 and PS21 for a reland?
This just changes to pass a MessagePipeHandle rather than InterfaceRequest over
the Blink-Chromium boundary in order to avoid leaking the Blink variant type
into Chromium (thanks to Sam for pointing out that this was a problem). It also
as a side-effect fixes the build error that caused this CL to be reverted, as
Platform.h no longer includes an auto-generated header (the issue there was that
Blink internal source code doesn't depend on the Blink public headers, so the
mojom.h wasn't guaranteed to get generated before they were built. That larger
issue is still present in the codebase of course but doesn't affect this CL
now).

[blundell, 2016-12-20 16:10:50]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that binds the connection to the
ServiceManager.
(2) Builds a bare-bones ServiceConnector around this connection that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
==========

[commit-bot: I haz the power, 2016-12-20 17:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 17:32:49]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-12-21 18:39:44]

lgtm

[blundell, 2016-12-22 07:08:44]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-12-22 07:08:45]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jochen@chromium.org, dcheng@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2460723003/#ps420001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-22 07:09:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 07:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 07:10:48]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[blundell, 2016-12-22 12:59:27]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-12-22 12:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jochen@chromium.org, esprehn@chromium.org, dcheng@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2460723003/#ps440001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-22 12:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 15:05:55]

CQ is committing da patch.

Bot data: {"patchset_id": 440001, "attempt_start_ts": 1482411567010210,
"parent_rev": "34603d1727b94b860a384996a3699094841cb395", "commit_rev":
"9a3510947539f76a752a2d786067d5440fd7c389"}

[commit-bot: I haz the power, 2016-12-22 15:06:24]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that binds the connection to the
ServiceManager.
(2) Builds a bare-bones ServiceConnector around this connection that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that binds the connection to the
ServiceManager.
(2) Builds a bare-bones ServiceConnector around this connection that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
Review-Url: https://codereview.chromium.org/2460723003
==========

[commit-bot: I haz the power, 2016-12-22 15:06:28]

Committed patchset #23 (id:440001)

[commit-bot: I haz the power, 2016-12-22 15:08:49]

Description was changed from

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that binds the connection to the
ServiceManager.
(2) Builds a bare-bones ServiceConnector around this connection that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Cr-Commit-Position: refs/heads/master@{#439498}
Review-Url: https://codereview.chromium.org/2460723003
==========

to

==========
Enable connection to Mojo services from Blink

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that binds the connection to the
ServiceManager.
(2) Builds a bare-bones ServiceConnector around this connection that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
Committed: https://crrev.com/32fc16c8f8cf5cba4a7bec4f6a18fcbdf32c5e3b
Cr-Original-Commit-Position: refs/heads/master@{#439498}
Cr-Commit-Position: refs/heads/master@{#440419}
==========

[commit-bot: I haz the power, 2016-12-22 15:08:52]

Patchset 23 (id:??) landed as
https://crrev.com/32fc16c8f8cf5cba4a7bec4f6a18fcbdf32c5e3b
Cr-Commit-Position: refs/heads/master@{#440419}