third_party/WebKit/Source/modules/time_zone_monitor/DEPS - Issue 2460723003: Enable connection to Mojo services from Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/time_zone_monitor/DEPS

Issue 2460723003: Enable connection to Mojo services from Blink (Closed)

Patch Set: Fix build Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+device/time_zone_monitor/public/interfaces/time_zone_monitor.mojom-blink.h ",	2 "+device/time_zone_monitor/public/interfaces/time_zone_monitor.mojom-blink.h ",

3 "+mojo/public/cpp/bindings/binding.h",	3 "+mojo/public/cpp/bindings/binding.h",

	4 "+services/device/public/cpp/constants.h",

	5 "+services/service_manager/public/cpp/connector.h",
	haraken 2016/11/08 23:56:59 I think it's better to reach consensus on this -- I think it's better to reach consensus on this -- whether it's okay for core/ and modules/ to depend on header files in //services/. Shall we discuss on platform-architecture-dev@? blundell 2016/11/09 11:54:42 Yeah, I totally agree. I had done the bulk of the Show quoted text On 2016/11/08 23:56:59, haraken wrote: > > I think it's better to reach consensus on this -- whether it's okay for core/ > and modules/ to depend on header files in //services/. Shall we discuss on > platform-architecture-dev@? > Yeah, I totally agree. I had done the bulk of the work on this CL before becoming aware of that issue. I'll start that conversation.
4 "+third_party/icu/source/i18n/unicode/timezone.h",	6 "+third_party/icu/source/i18n/unicode/timezone.h",

5 ]	7 ]

OLD	NEW