Enable connection to Mojo services from Blink

third_party/WebKit/public/platform/Platform.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
 #include "WebSize.h"
 #include "WebSpeechSynthesizer.h"
 #include "WebStorageQuotaCallbacks.h"
 #include "WebStorageQuotaType.h"
 #include "WebString.h"
 #include "WebURLError.h"
 #include "WebVector.h"
 #include "base/metrics/user_metrics_action.h"
 #include "cc/resources/shared_bitmap.h"
 #include "cc/surfaces/frame_sink_id.h"
+#include "services/service_manager/public/interfaces/connector.mojom-blink.h"

[Sam McNally, 2016/12/20 07:29:38]

We shouldn't exposing blink-variant mojoms outside blink.

[blundell, 2016/12/20 07:39:43]

Can you elaborate? I understand that in general, the Blink variants are for
usage strictly within Blink. This exposure is that so that the embedder can give
Blink its service connection. I can do this via an untyped handle, but just
curious on what the exact reasoning is in this case.

[Sam McNally, 2016/12/20 08:57:18]

Blink variants of mojoms include WTF types. Using them in blink public
interfaces leaks them into the rest of the codebase. See
https://bugs.chromium.org/p/chromium/issues/detail?id=621177 for another case
where this occurred.

[blundell, 2016/12/20 09:01:57]

Got it, thanks. In making this change, I'll also be able to reland this CL :).

 
 namespace gpu {
 class GpuMemoryBufferManager;
 }
 
 namespace v8 {
 class Context;
 template <class T>
 class Local;
 }
@@ skipping 528 matching lines @@
   }
 
   // WebCrypto ----------------------------------------------------------
 
   virtual WebCrypto* crypto() { return nullptr; }
 
   // Mojo ---------------------------------------------------------------
 
   virtual InterfaceProvider* interfaceProvider();
 
+  virtual void bindServiceConnector(
+      service_manager::mojom::blink::ConnectorRequest);
+
   // Platform events -----------------------------------------------------
   // Device Orientation, Device Motion, Device Light, Battery, Gamepad.
 
   // Request the platform to start listening to the events of the specified
   // type and notify the given listener (if not null) when there is an update.
   virtual void startListening(WebPlatformEventType type,
                               WebPlatformEventListener* listener) {}
 
   // Request the platform to stop listening to the specified event and no
   // longer notify the listener, if any.
@@ skipping 58 matching lines @@
  protected:
   Platform();
   virtual ~Platform() {}
 
   WebThread* m_mainThread;
 };
 
 }  // namespace blink
 
 #endif