Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2460163002: Refactor QuicServerSessionBase::Visitor (Closed)

Created:
4 years, 1 month ago by Buck
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor QuicServerSessionBase::Visitor The bulk goes into QuicSession::Visitor to make it clear that Quic is independent of SPDY. The remaining function specific to GFE goes into the GFE layer with the concrete type it is expecting. Non-functional refactor. Move QuicServerSessionBase::Visitor to QuicSession::Visitor, create GfeQuicServerSession::Visitor that provides the additional function GfeQuicServerSession expects of its visitor (+ some refactoring of types in GfeQuicServerSession/GfeQuicDispatcher now that the types are better-defined). Merge internal change: 136840549 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -88 lines) Patch
M net/quic/core/quic_client_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_server_session_base.h View 3 chunks +2 lines, -29 lines 0 comments Download
M net/quic/core/quic_server_session_base.cc View 2 chunks +1 line, -9 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_session.h View 5 chunks +28 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +9 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 3 chunks +10 lines, -3 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_server_session_visitor.h View 2 chunks +8 lines, -9 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_server_session_visitor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_time_wait_list_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_server.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
Buck
4 years, 1 month ago (2016-10-29 05:33:16 UTC) #1
Ryan Hamilton
4 years, 1 month ago (2016-10-29 14:42:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698