Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Issue 2460223002: Adds std:: to stl types (#049) (Closed)

Created:
4 years, 1 month ago by Buck
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

in order to disable internal global using declarations, this CL qualifies stl types with std namespace. Merge internal change: 136849591 BUG=

Patch Set 1 #

Patch Set 2 : for review #

Total comments: 1

Patch Set 3 : eliminate std::foo with using std::foo #

Patch Set 4 : remove dead using std::foo declarations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -106 lines) Patch
M net/quic/core/crypto/cert_compressor.cc View 1 2 3 9 chunks +24 lines, -25 lines 0 comments Download
M net/quic/core/crypto/cert_compressor_test.cc View 1 2 3 6 chunks +9 lines, -10 lines 0 comments Download
M net/quic/core/crypto/crypto_framer.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_framer_test.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M net/quic/core/crypto/crypto_utils.cc View 3 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache_test.cc View 1 2 3 4 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 2 3 10 chunks +19 lines, -21 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/strike_register.cc View 1 2 3 10 chunks +19 lines, -22 lines 0 comments Download
M net/quic/core/crypto/strike_register_test.cc View 3 3 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (7 generated)
Buck
4 years, 1 month ago (2016-10-30 16:08:18 UTC) #5
Ryan Hamilton
4 years, 1 month ago (2016-10-30 20:22:30 UTC) #9
lgtm

https://codereview.chromium.org/2460223002/diff/20001/net/quic/core/crypto/ce...
File net/quic/core/crypto/cert_compressor.cc (right):

https://codereview.chromium.org/2460223002/diff/20001/net/quic/core/crypto/ce...
net/quic/core/crypto/cert_compressor.cc:16: using std::vector;
ditto.

Powered by Google App Engine
This is Rietveld 408576698