Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: net/tools/quic/quic_dispatcher.h

Issue 2460163002: Refactor QuicServerSessionBase::Visitor (Closed)
Patch Set: Updated patchset dependency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/tools/quic/quic_simple_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher.h
diff --git a/net/tools/quic/quic_dispatcher.h b/net/tools/quic/quic_dispatcher.h
index 8f5db502c5d0fff2131f55bd72bf38b1fe78836b..229362975f6e0b411ad9c81e48f579fc2936679c 100644
--- a/net/tools/quic/quic_dispatcher.h
+++ b/net/tools/quic/quic_dispatcher.h
@@ -37,7 +37,7 @@ namespace test {
class QuicDispatcherPeer;
} // namespace test
-class QuicDispatcher : public QuicServerSessionBase::Visitor,
+class QuicDispatcher : public QuicTimeWaitListManager::Visitor,
public ProcessPacketInterface,
public QuicBlockedWriterInterface,
public QuicFramerVisitorInterface,
@@ -76,21 +76,24 @@ class QuicDispatcher : public QuicServerSessionBase::Visitor,
// Sends ConnectionClose frames to all connected clients.
void Shutdown();
- // QuicServerSessionBase::Visitor interface implementation:
+ // QuicSession::Visitor interface implementation (via inheritance of
+ // QuicTimeWaitListManager::Visitor):
// Ensure that the closed connection is cleaned up asynchronously.
void OnConnectionClosed(QuicConnectionId connection_id,
QuicErrorCode error,
const std::string& error_details) override;
+ // QuicSession::Visitor interface implementation (via inheritance of
+ // QuicTimeWaitListManager::Visitor):
// Queues the blocked writer for later resumption.
void OnWriteBlocked(QuicBlockedWriterInterface* blocked_writer) override;
- // Called whenever the time wait list manager adds a new connection to the
- // time-wait list.
+ // QuicTimeWaitListManager::Visitor interface implementation
+ // Called whenever the time wait std::list manager adds a new connection to
+ // the
+ // time-wait std::list.
void OnConnectionAddedToTimeWaitList(QuicConnectionId connection_id) override;
- void OnPacketBeingDispatchedToSession(QuicSession* session) override {}
-
using SessionMap =
std::unordered_map<QuicConnectionId, std::unique_ptr<QuicSession>>;
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/tools/quic/quic_simple_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698