Issue 2464603002: Break reliance of QuicDispatcher on QuicServerSessionBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2464603002: Break reliance of QuicDispatcher on QuicServerSessionBase (Closed)

Created:
4 years, 1 month ago by Buck

Modified:
4 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Break reliance of QuicDispatcher on QuicServerSessionBase QuicServerSessionBase implies SPDY/HTTP semantics which violates the abstraction layer of QUIC being a protocol-layer transport. Refactor QuicDispatcher to use QuicSession rather than have a false dependency on QuicServerSessionBase. Should be a pure refactor (no functional changes). Merge internal change: 136479337 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -23 lines)			Patch
M	net/quic/core/quic_server_session_base.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.h	View	5 chunks	+9 lines, -11 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	net/tools/quic/test_tools/mock_quic_server_session_visitor.h	View	1 chunk	+1 line, -2 lines	0 comments	Download

Depends on Patchset:

Issue 2462823002 Patch 20001

Dependent Patchsets:

Issue 2460163002 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages