WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
Committed: https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8
Cr-Commit-Position: refs/heads/master@{#432875}

[pilgrim_google, 2016-10-28 18:47:12]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:47:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:28:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pilgrim_google, 2016-11-03 17:30:47]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 17:31:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pilgrim_google, 2016-11-03 17:32:22]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, tkent@chromium.org

[esprehn, 2016-11-03 19:57:17]

C++11 returns a reference to the new value from emplace_back(), should we be
doing that too?

[commit-bot: I haz the power, 2016-11-03 22:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:30:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-11-03 23:47:55]

Can we create a tracking bug for these efforts?

[tkent, 2016-11-03 23:53:37]

Will this effort be affected by Blink naming rule conversion planed at the end
of this year?  I'm afraid emplace_back() will be renamed to EmplacedBack()
automatically.

[haraken, 2016-11-03 23:55:06]

On 2016/11/03 23:53:37, tkent wrote:
> Will this effort be affected by Blink naming rule conversion planed at the end
> of this year?  I'm afraid emplace_back() will be renamed to EmplacedBack()
> automatically.

I was thinking that our plan is to allow the xxx_yyy style for simple methods.

[esprehn, 2016-11-03 23:56:27]

The rename has a black list for methods and properties in WTF otherwise ex.
begin() becomes Begin() and everything that expects iterators is broken.
This method won't be renamed. :)

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[esprehn, 2016-11-03 23:56:27]

The rename has a black list for methods and properties in WTF otherwise ex.
begin() becomes Begin() and everything that expects iterators is broken.
This method won't be renamed. :)

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[pilgrim_google, 2016-11-04 16:13:23]

Description was changed from

==========
WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...>

BUG=
==========

to

==========
WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...>

BUG=662431
==========

[pilgrim_google, 2016-11-04 16:14:20]

Description was changed from

==========
WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...>

BUG=662431
==========

to

==========
WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

[pilgrim_google, 2016-11-04 16:15:08]

On 2016/11/03 at 23:47:55, haraken wrote:
> Can we create a tracking bug for these efforts?

Done!

[esprehn, 2016-11-04 23:49:35]

https://codereview.chromium.org/2457163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Vector.h (right):

https://codereview.chromium.org/2457163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Vector.h:1399: ALWAYS_INLINE void Vector<T,
inlineCapacity, Allocator>::emplace_back(
std emplace_back returns a reference, should this do that too?

[pilgrim_google, 2016-11-15 21:52:44]

On 2016/11/04 at 23:49:35, esprehn wrote:
>
https://codereview.chromium.org/2457163002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/wtf/Vector.h (right):
> 
>
https://codereview.chromium.org/2457163002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/wtf/Vector.h:1399: ALWAYS_INLINE void Vector<T,
inlineCapacity, Allocator>::emplace_back(
> std emplace_back returns a reference, should this do that too?

I have no opinion on this. Can someone offer either an opinion or an LGTM to
move this CL forward?

[jsbell, 2016-11-16 18:08:00]

On 2016/11/15 21:52:44, pilgrim_google wrote:

>
https://codereview.chromium.org/2457163002/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/wtf/Vector.h:1399: ALWAYS_INLINE void Vector<T,
> inlineCapacity, Allocator>::emplace_back(
> > std emplace_back returns a reference, should this do that too?
> 
> I have no opinion on this. Can someone offer either an opinion or an LGTM to
> move this CL forward?

Since we're here touching the method anyway, I say +1 to doing it. (i.e. return
a reference, matching std::vector::emplace_back signature as closely as
possible). Should not affect other code or performance (as no-one is using it)
and it's one less surprise down the road for someone coming from STL.

[pilgrim_google, 2016-11-16 19:51:01]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2016-11-16 19:51:17]

On 2016/11/16 at 18:08:00, jsbell wrote:
> On 2016/11/15 21:52:44, pilgrim_google wrote:
> 
> >
https://codereview.chromium.org/2457163002/diff/20001/third_party/WebKit/Sour...
> > > third_party/WebKit/Source/wtf/Vector.h:1399: ALWAYS_INLINE void Vector<T,
> > inlineCapacity, Allocator>::emplace_back(
> > > std emplace_back returns a reference, should this do that too?
> > 
> > I have no opinion on this. Can someone offer either an opinion or an LGTM to
> > move this CL forward?
> 
> Since we're here touching the method anyway, I say +1 to doing it. (i.e.
return a reference, matching std::vector::emplace_back signature as closely as
possible). Should not affect other code or performance (as no-one is using it)
and it's one less surprise down the road for someone coming from STL.

Done! Please re-review.

[commit-bot: I haz the power, 2016-11-16 19:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 21:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 21:57:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-11-17 04:50:51]

LGTM

[pilgrim_google, 2016-11-17 13:21:19]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-11-17 13:21:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:58:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 15:01:15]

Description was changed from

==========
WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Committed: https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8
Cr-Commit-Position: refs/heads/master@{#432875}
==========

[commit-bot: I haz the power, 2016-11-17 15:01:16]

Patchset 3 (id:??) landed as
https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8
Cr-Commit-Position: refs/heads/master@{#432875}