third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc - Issue 2457163002: WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

Issue 2457163002: WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back (Closed)

Patch Set: rebase + return reference to emplaced element Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

index 34d135e9be481d5e0f73f9dfbe2caf4b2b04dd60..fcb583502e3ffc1f29193c224d7efdc1753a2fef 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

@@ -20,14 +20,14 @@ void NGLayoutInlineItemsBuilder::Append(const String& string,

const ComputedStyle* style) {

unsigned start_offset = text_.length();

text_.append(string);

- items_->emplaceAppend(start_offset, text_.length(), style);

+ items_->emplace_back(start_offset, text_.length(), style);

}

void NGLayoutInlineItemsBuilder::Append(UChar32 character,

const ComputedStyle* style) {

text_.append(character);

unsigned end_offset = text_.length();

- items_->emplaceAppend(end_offset - 1, end_offset, style);

+ items_->emplace_back(end_offset - 1, end_offset, style);

}

void NGLayoutInlineItemsBuilder::AppendBidiControl(const ComputedStyle* style,

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc ('k') | third_party/WebKit/Source/wtf/Vector.h » ('j') | no next file with comments »