third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc - Issue 2457163002: WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc

Issue 2457163002: WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back (Closed)

Patch Set: rebase + return reference to emplaced element Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc

index bf487d1340b557aafe383e3073a6abff1aee2f43..a3b9e2c61f6c4282b808fca40887ed0e99c952c0 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc

@@ -24,7 +24,7 @@ class NGInlineBoxForTest : public NGInlineBox {

void AppendText(const String& text) {

unsigned start = text_content_.length();

text_content_.append(text);

- items_.emplaceAppend(start, start + text.length(), nullptr);

+ items_.emplace_back(start, start + text.length(), nullptr);

}

void AppendText(const char16_t* text) {