Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

Issue 2457163002: WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back (Closed)
Patch Set: rebase + return reference to emplaced element Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
index 56ab63e3309ae6fa67c885eb4fd25d99ad662c30..1568332b39b94dd74d8f7288b6088919e0b4779a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
@@ -603,8 +603,8 @@ TEST(V8ScriptValueSerializerTest, DecodeBlobIndex) {
RefPtr<SerializedScriptValue> input =
serializedValue({0xff, 0x09, 0x3f, 0x00, 0x69, 0x00});
WebBlobInfoArray blobInfoArray;
- blobInfoArray.emplaceAppend("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
- "text/plain", 12);
+ blobInfoArray.emplace_back("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
+ "text/plain", 12);
V8ScriptValueDeserializer deserializer(scope.getScriptState(), input);
deserializer.setBlobInfoArray(&blobInfoArray);
v8::Local<v8::Value> result = deserializer.deserialize();
@@ -626,8 +626,8 @@ TEST(V8ScriptValueSerializerTest, DecodeBlobIndexOutOfRange) {
}
{
WebBlobInfoArray blobInfoArray;
- blobInfoArray.emplaceAppend("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
- "text/plain", 12);
+ blobInfoArray.emplace_back("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
+ "text/plain", 12);
V8ScriptValueDeserializer deserializer(scope.getScriptState(), input);
deserializer.setBlobInfoArray(&blobInfoArray);
ASSERT_TRUE(deserializer.deserialize()->IsNull());
@@ -870,8 +870,8 @@ TEST(V8ScriptValueSerializerTest, DecodeFileIndex) {
RefPtr<SerializedScriptValue> input =
serializedValue({0xff, 0x09, 0x3f, 0x00, 0x65, 0x00});
WebBlobInfoArray blobInfoArray;
- blobInfoArray.emplaceAppend("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
- "/native/path", "path", "text/plain");
+ blobInfoArray.emplace_back("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
+ "/native/path", "path", "text/plain");
V8ScriptValueDeserializer deserializer(scope.getScriptState(), input);
deserializer.setBlobInfoArray(&blobInfoArray);
v8::Local<v8::Value> result = deserializer.deserialize();
@@ -894,8 +894,8 @@ TEST(V8ScriptValueSerializerTest, DecodeFileIndexOutOfRange) {
}
{
WebBlobInfoArray blobInfoArray;
- blobInfoArray.emplaceAppend("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
- "/native/path", "path", "text/plain");
+ blobInfoArray.emplace_back("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
+ "/native/path", "path", "text/plain");
V8ScriptValueDeserializer deserializer(scope.getScriptState(), input);
deserializer.setBlobInfoArray(&blobInfoArray);
ASSERT_TRUE(deserializer.deserialize()->IsNull());
@@ -1028,8 +1028,8 @@ TEST(V8ScriptValueSerializerTest, DecodeFileListIndex) {
RefPtr<SerializedScriptValue> input =
serializedValue({0xff, 0x09, 0x3f, 0x00, 0x4c, 0x01, 0x00, 0x00});
WebBlobInfoArray blobInfoArray;
- blobInfoArray.emplaceAppend("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
- "/native/path", "name", "text/plain");
+ blobInfoArray.emplace_back("d875dfc2-4505-461b-98fe-0cf6cc5eaf44",
+ "/native/path", "name", "text/plain");
V8ScriptValueDeserializer deserializer(scope.getScriptState(), input);
deserializer.setBlobInfoArray(&blobInfoArray);
v8::Local<v8::Value> result = deserializer.deserialize();

Powered by Google App Engine
This is Rietveld 408576698