Fixes to WindowTreeHostMus

Fixes to WindowTreeHostMus

This adds the display_id, makes the Window associated with the
WindowTreeHostMus always have an origin of 0x0 and track size of
underlying window, and makes visibility of WindowTreeHostMus match
that window.

BUG=659155
TEST=covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/253a1515bbb87cd76bf6f08924b1f1333ba79958
Cr-Commit-Position: refs/heads/master@{#428260}

[sky, 2016-10-27 16:10:37]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 16:11:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 16:15:04]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-10-27 16:27:34]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 16:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:45:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 16:45:48]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sky, 2016-10-27 16:48:24]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 16:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 17:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:51:34]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-10-27 20:26:18]

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus.h
File ui/aura/mus/window_mus.h (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
ui/aura/mus/window_mus.h:81: // Called in the rare case when WindowTreeClient
needs to state and can't go
"...needs to +change state"?

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
ui/aura/mus/window_mus.h:88: virtual std::unique_ptr<WindowMusChangeData>
PrepareForServerVisibilityChange(
It doesn't look like the visibility one is being used yet.

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.cc:575:
window->PrepareForServerBoundsChange(window_tree_host_bounds);
This is really complex!

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_host_mus.h (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus.h:46: explicit
WindowTreeHostMus(std::unique_ptr<WindowPortMus> window_port,
No explicit

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus.h:53: void SetBoundsFromServer(const gfx::Rect&
bounds);
In dip or physical pixels?

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_host_mus_delegate.h (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus_delegate.h:23: virtual void
SetRootWindowBounds(Window* window, gfx::Rect* bounds) = 0;
WindowTreeHost::bounds is in physical-pixel space right now. What pixel-space is
|bounds| in here?

[sadrul, 2016-10-27 21:59:52]

On 2016/10/27 20:26:18, sadrul wrote:
> https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus.h
> File ui/aura/mus/window_mus.h (right):
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
> ui/aura/mus/window_mus.h:81: // Called in the rare case when WindowTreeClient
> needs to state and can't go
> "...needs to +change state"?
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
> ui/aura/mus/window_mus.h:88: virtual std::unique_ptr<WindowMusChangeData>
> PrepareForServerVisibilityChange(
> It doesn't look like the visibility one is being used yet.
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> File ui/aura/mus/window_tree_client.cc (right):
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> ui/aura/mus/window_tree_client.cc:575:
> window->PrepareForServerBoundsChange(window_tree_host_bounds);
> This is really complex!
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> File ui/aura/mus/window_tree_host_mus.h (right):
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> ui/aura/mus/window_tree_host_mus.h:46: explicit
> WindowTreeHostMus(std::unique_ptr<WindowPortMus> window_port,
> No explicit
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> ui/aura/mus/window_tree_host_mus.h:53: void SetBoundsFromServer(const
gfx::Rect&
> bounds);
> In dip or physical pixels?
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> File ui/aura/mus/window_tree_host_mus_delegate.h (right):
> 
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> ui/aura/mus/window_tree_host_mus_delegate.h:23: virtual void
> SetRootWindowBounds(Window* window, gfx::Rect* bounds) = 0;
> WindowTreeHost::bounds is in physical-pixel space right now. What pixel-space
is
> |bounds| in here?

Ria and I will figure out the physical vs dip thing. This lgtm

[sky, 2016-10-27 22:14:44]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[sky, 2016-10-27 22:15:04]

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus.h
File ui/aura/mus/window_mus.h (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
ui/aura/mus/window_mus.h:81: // Called in the rare case when WindowTreeClient
needs to state and can't go
On 2016/10/27 20:26:17, sadrul wrote:
> "...needs to +change state"?

Done.

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
ui/aura/mus/window_mus.h:88: virtual std::unique_ptr<WindowMusChangeData>
PrepareForServerVisibilityChange(
On 2016/10/27 20:26:17, sadrul wrote:
> It doesn't look like the visibility one is being used yet.

It should have. I added test coverage, which uncovered a couple of problems that
I've fixed here.

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.cc:575:
window->PrepareForServerBoundsChange(window_tree_host_bounds);
On 2016/10/27 20:26:17, sadrul wrote:
> This is really complex!

Indeed. If you have better ideas I'm all for it.

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_host_mus.h (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus.h:46: explicit
WindowTreeHostMus(std::unique_ptr<WindowPortMus> window_port,
On 2016/10/27 20:26:17, sadrul wrote:
> No explicit

Done.

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus.h:53: void SetBoundsFromServer(const gfx::Rect&
bounds);
On 2016/10/27 20:26:17, sadrul wrote:
> In dip or physical pixels?

I commented it's in dips, but I could be wrong as it seems to me the dips/pixels
are still in work in progress.

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_host_mus_delegate.h (right):

https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_host_mus_delegate.h:23: virtual void
SetRootWindowBounds(Window* window, gfx::Rect* bounds) = 0;
On 2016/10/27 20:26:17, sadrul wrote:
> WindowTreeHost::bounds is in physical-pixel space right now. What pixel-space
is
> |bounds| in here?

I commented dips, but similar concern with other place you mentioend.

[sky, 2016-10-27 22:15:42]

On 2016/10/27 21:59:52, sadrul wrote:
> On 2016/10/27 20:26:18, sadrul wrote:
> >
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus.h
> > File ui/aura/mus/window_mus.h (right):
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
> > ui/aura/mus/window_mus.h:81: // Called in the rare case when
WindowTreeClient
> > needs to state and can't go
> > "...needs to +change state"?
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_mus....
> > ui/aura/mus/window_mus.h:88: virtual std::unique_ptr<WindowMusChangeData>
> > PrepareForServerVisibilityChange(
> > It doesn't look like the visibility one is being used yet.
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > File ui/aura/mus/window_tree_client.cc (right):
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > ui/aura/mus/window_tree_client.cc:575:
> > window->PrepareForServerBoundsChange(window_tree_host_bounds);
> > This is really complex!
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > File ui/aura/mus/window_tree_host_mus.h (right):
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > ui/aura/mus/window_tree_host_mus.h:46: explicit
> > WindowTreeHostMus(std::unique_ptr<WindowPortMus> window_port,
> > No explicit
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > ui/aura/mus/window_tree_host_mus.h:53: void SetBoundsFromServer(const
> gfx::Rect&
> > bounds);
> > In dip or physical pixels?
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > File ui/aura/mus/window_tree_host_mus_delegate.h (right):
> > 
> >
>
https://codereview.chromium.org/2456623002/diff/80001/ui/aura/mus/window_tree...
> > ui/aura/mus/window_tree_host_mus_delegate.h:23: virtual void
> > SetRootWindowBounds(Window* window, gfx::Rect* bounds) = 0;
> > WindowTreeHost::bounds is in physical-pixel space right now. What
pixel-space
> is
> > |bounds| in here?
> 
> Ria and I will figure out the physical vs dip thing. This lgtm

Thanks! As I commented it feels like the dip/pixel thing is in flux.

[sky, 2016-10-27 22:15:48]

The CQ bit was unchecked by sky@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-10-27 22:15:52]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-27 22:15:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2456623002/#ps140001
(title: "moar")

[commit-bot: I haz the power, 2016-10-27 22:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:03:44]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sky, 2016-10-27 23:40:20]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-27 23:40:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2456623002/#ps160001
(title: "merge")

[commit-bot: I haz the power, 2016-10-27 23:40:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 01:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:47:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2016-10-28 01:48:44]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:49:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:36:51]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-10-28 02:38:46]

Description was changed from

==========
Fixes to WindowTreeHostMus

This adds the display_id, makes the Window associated with the
WindowTreeHostMus always have an origin of 0x0 and track size of
underlying window, and makes visibility of WindowTreeHostMus match
that window.

BUG=659155
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Fixes to WindowTreeHostMus

This adds the display_id, makes the Window associated with the
WindowTreeHostMus always have an origin of 0x0 and track size of
underlying window, and makes visibility of WindowTreeHostMus match
that window.

BUG=659155
TEST=covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/253a1515bbb87cd76bf6f08924b1f1333ba79958
Cr-Commit-Position: refs/heads/master@{#428260}
==========

[commit-bot: I haz the power, 2016-10-28 02:38:47]

Patchset 9 (id:??) landed as
https://crrev.com/253a1515bbb87cd76bf6f08924b1f1333ba79958
Cr-Commit-Position: refs/heads/master@{#428260}