Wires up transient windows for aura-mus

Wires up transient windows for aura-mus

BUG=659155
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/65cfc29015f28181b316b5a16b12bca79cd9e570
Cr-Commit-Position: refs/heads/master@{#428280}

[sky, 2016-10-27 22:36:31]

https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_wind...
File ui/wm/public/transient_window_client.h (left):

https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_wind...
ui/wm/public/transient_window_client.h:6: #define
UI_WM_PUBLIC_TRANSIENT_WINDOW_CLIENT_H_
I copied this rather than moving here https://codereview.chromium.org/2453953003
. That was a mistake. This removes the file.

[msw, 2016-10-27 23:46:11]

lgtm, but I'm a bit confused about the test patterns.

https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_wind...
File ui/wm/public/transient_window_client.h (left):

https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_wind...
ui/wm/public/transient_window_client.h:6: #define
UI_WM_PUBLIC_TRANSIENT_WINDOW_CLIENT_H_
On 2016/10/27 22:36:31, sky wrote:
> I copied this rather than moving here
https://codereview.chromium.org/2453953003
> . That was a mistake. This removes the file.

Gotcha, thanks for the note.

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.h (right):

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.h:107: // Applies to ADD, ADD_TRANSIENT, REMOVE and
REORDER.
optional nit: mention REMOVE_TRANSIENT, or just etc.?

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client_unittest.cc (right):

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:838: Window transient(nullptr);
Is this |transient| owned by |parent|, like |transient_child| on line 975? If
not, I fail to see how a difference in ownership is established. Is it the
removal of the transient from its parent within this test fixture (that somehow
restores ownership to the local |transient| object) versus the destruction of
|transient_parent| at line 992 that somehow determines the lifetime/ownership of
the Window object? That doesn't make sense... I'm just a bit confused.

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/test/mus/test_w...
File ui/aura/test/mus/test_window_tree.h (right):

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/test/mus/test_w...
ui/aura/test/mus/test_window_tree.h:79: // Data from most recent add/remove
transient window.
nit: "the most recently added/removed"?

[sky, 2016-10-28 03:16:33]

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_port...
File ui/aura/mus/window_port_mus.h (right):

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_port...
ui/aura/mus/window_port_mus.h:107: // Applies to ADD, ADD_TRANSIENT, REMOVE and
REORDER.
On 2016/10/27 23:46:10, msw wrote:
> optional nit: mention REMOVE_TRANSIENT, or just etc.?

Done.

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client_unittest.cc (right):

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:838: Window transient(nullptr);
On 2016/10/27 23:46:10, msw wrote:
> Is this |transient| owned by |parent|, like |transient_child| on line 975?

This test changes the transient status a bunch. So, transient is transient at
line 842, then made not transient at 849, transient again at 855 and finally
removed as a transient on 860.

> If
> not, I fail to see how a difference in ownership is established. Is it the
> removal of the transient from its parent within this test fixture (that
somehow
> restores ownership to the local |transient| object) versus the destruction of
> |transient_parent| at line 992 that somehow determines the lifetime/ownership
of
> the Window object? That doesn't make sense... I'm just a bit confused.

Hopefully my description clears it up. 

The test WindowDestroyedWhileTransientChildHasCapture destroys a window with a
transient still around and verifies the transient is actually destroyed.

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/test/mus/test_w...
File ui/aura/test/mus/test_window_tree.h (right):

https://codereview.chromium.org/2456843004/diff/20001/ui/aura/test/mus/test_w...
ui/aura/test/mus/test_window_tree.h:79: // Data from most recent add/remove
transient window.
On 2016/10/27 23:46:10, msw wrote:
> nit: "the most recently added/removed"?

Done.

[sky, 2016-10-28 03:16:45]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-28 03:16:46]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2456843004/#ps60001
(title: "feedback")

[sky, 2016-10-28 03:16:59]

The CQ bit was unchecked by sky@chromium.org

[sky, 2016-10-28 03:17:37]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-28 03:17:37]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2456843004/#ps80001
(title: "relative to master")

[commit-bot: I haz the power, 2016-10-28 03:17:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 04:21:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-28 04:23:22]

Description was changed from

==========
Wires up transient windows for aura-mus

BUG=659155
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Wires up transient windows for aura-mus

BUG=659155
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/65cfc29015f28181b316b5a16b12bca79cd9e570
Cr-Commit-Position: refs/heads/master@{#428280}
==========

[commit-bot: I haz the power, 2016-10-28 04:23:22]

Patchset 5 (id:??) landed as
https://crrev.com/65cfc29015f28181b316b5a16b12bca79cd9e570
Cr-Commit-Position: refs/heads/master@{#428280}