Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2456843004: Wires up transient windows for aura-mus (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up transient windows for aura-mus BUG=659155 TEST=covered by tests R=msw@chromium.org Committed: https://crrev.com/65cfc29015f28181b316b5a16b12bca79cd9e570 Cr-Commit-Position: refs/heads/master@{#428280}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Total comments: 6

Patch Set 3 : merge #

Patch Set 4 : feedback #

Patch Set 5 : relative to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -123 lines) Patch
M ui/aura/mus/window_mus.h View 2 chunks +13 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M ui/aura/mus/window_port_mus.cc View 1 3 chunks +46 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 5 chunks +41 lines, -13 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 2 3 chunks +53 lines, -35 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.h View 1 2 3 4 chunks +13 lines, -0 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
D ui/wm/public/transient_window_client.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/wm/public/transient_window_client.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sky
https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_window_client.h File ui/wm/public/transient_window_client.h (left): https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_window_client.h#oldcode6 ui/wm/public/transient_window_client.h:6: #define UI_WM_PUBLIC_TRANSIENT_WINDOW_CLIENT_H_ I copied this rather than moving here ...
4 years, 1 month ago (2016-10-27 22:36:31 UTC) #1
msw
lgtm, but I'm a bit confused about the test patterns. https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_window_client.h File ui/wm/public/transient_window_client.h (left): https://codereview.chromium.org/2456843004/diff/1/ui/wm/public/transient_window_client.h#oldcode6 ...
4 years, 1 month ago (2016-10-27 23:46:11 UTC) #2
sky
https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_port_mus.h File ui/aura/mus/window_port_mus.h (right): https://codereview.chromium.org/2456843004/diff/20001/ui/aura/mus/window_port_mus.h#newcode107 ui/aura/mus/window_port_mus.h:107: // Applies to ADD, ADD_TRANSIENT, REMOVE and REORDER. On ...
4 years, 1 month ago (2016-10-28 03:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456843004/80001
4 years, 1 month ago (2016-10-28 03:17:59 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-28 04:21:27 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 04:23:22 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/65cfc29015f28181b316b5a16b12bca79cd9e570
Cr-Commit-Position: refs/heads/master@{#428280}

Powered by Google App Engine
This is Rietveld 408576698