Fixes to WindowTreeHostMus

ui/aura/mus/window_mus.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_AURA_MUS_WINDOW_MUS_H_
 #define UI_AURA_MUS_WINDOW_MUS_H_
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
 #include "services/ui/public/interfaces/cursor.mojom.h"
 #include "ui/aura/aura_export.h"
 #include "ui/aura/mus/mus_types.h"
 
 namespace gfx {
 class Rect;
+class Vector2d;
 }
 
 namespace ui {
 namespace mojom {
 enum class OrderDirection;
 }
 }
 
 namespace aura {
 
 struct SurfaceInfo;
 class Window;
 class WindowTreeClient;
 
+// See PrepareForServerBoundsChange() for details on this.
+struct AURA_EXPORT WindowMusChangeData {
+  virtual ~WindowMusChangeData() {}
+};
+
 // WindowMus defines the interface used by WindowTreeClient to modify
 // the underlying Window. It's defined as a separate interface to make it clear
 // that any changes that WindowTreeClient makes must be propagated through
 // this interface so that they don't result in bouncing back to
 // WindowTreeClient. For example, if the server change the bounds care must be
 // taken that when the change is applied to the Window the server isn't asked to
 // change the bounds too. See WindowPortMus for details.
 class AURA_EXPORT WindowMus {
  public:
   virtual ~WindowMus() {}
@@ skipping 22 matching lines @@
                                  ui::mojom::OrderDirection) = 0;
   virtual void SetBoundsFromServer(const gfx::Rect& bounds) = 0;
   virtual void SetVisibleFromServer(bool visible) = 0;
   virtual void SetOpacityFromServer(float opacity) = 0;
   virtual void SetPredefinedCursorFromServer(ui::mojom::Cursor cursor) = 0;
   virtual void SetPropertyFromServer(const std::string& property_name,
                                      const std::vector<uint8_t>* data) = 0;
   virtual void SetSurfaceIdFromServer(
       std::unique_ptr<SurfaceInfo> surface_info) = 0;
 
+  // Called in the rare case when WindowTreeClient needs to state and can't go

[sadrul, 2016/10/27 20:26:17]

"...needs to +change state"?

[sky, 2016/10/27 22:15:04]

Done.

+  // through one of the SetFooFromServer() functions above. Generally because
+  // it needs to call another function that as a side effect changes the window.
+  // Once the call to the underlying window has completed the returned object
+  // should be destroyed.
+  virtual std::unique_ptr<WindowMusChangeData> PrepareForServerBoundsChange(
+      const gfx::Rect& bounds) = 0;
+  virtual std::unique_ptr<WindowMusChangeData> PrepareForServerVisibilityChange(

[sadrul, 2016/10/27 20:26:17]

It doesn't look like the visibility one is being used yet.

[sky, 2016/10/27 22:15:04]

It should have. I added test coverage, which uncovered a couple of problems that
I've fixed here.

+      bool value) = 0;
+
   virtual void NotifyEmbeddedAppDisconnected() = 0;
 
  private:
   // Just for set_server_id(), which other places should not call.
   friend class WindowTreeClient;
 
   void set_server_id(Id id) { server_id_ = id; }
 
   Id server_id_ = kInvalidServerId;
 };
 
 }  // namespace aura
 
 #endif  // UI_AURA_MUS_WINDOW_MUS_H_